From db1d0184ef1b1334c6923a65783d0482979d7c41 Mon Sep 17 00:00:00 2001 From: Andrew Carroll Date: Thu, 8 Aug 2013 10:49:23 -0400 Subject: [PATCH 1/3] Fixed issue causing blockquotes not to apply to any children beyond first child --- lib/html2markdown/converter.rb | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/lib/html2markdown/converter.rb b/lib/html2markdown/converter.rb index 21905a3..467fcc7 100644 --- a/lib/html2markdown/converter.rb +++ b/lib/html2markdown/converter.rb @@ -44,7 +44,11 @@ def wrap_node(node,contents=nil) result << "*#{contents}\n" when 'blockquote' contents.split('\n').each do |part| - result << ">#{contents}\n" + if not part.empty? + result << ">#{part}\n" + else + result << "\n" + end end when 'strong' result << "**#{contents}**\n" From b4eaf30c22e61b6019c0ced15a838412dc2be828 Mon Sep 17 00:00:00 2001 From: Andrew Carroll Date: Sat, 10 Aug 2013 19:27:53 -0400 Subject: [PATCH 2/3] Improved previous fix --- lib/html2markdown/converter.rb | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/lib/html2markdown/converter.rb b/lib/html2markdown/converter.rb index 467fcc7..a16c824 100644 --- a/lib/html2markdown/converter.rb +++ b/lib/html2markdown/converter.rb @@ -43,11 +43,9 @@ def wrap_node(node,contents=nil) when 'li' result << "*#{contents}\n" when 'blockquote' - contents.split('\n').each do |part| - if not part.empty? - result << ">#{part}\n" - else - result << "\n" + contents.split("\n").each do |part| + if not part.strip.empty? + result << ">#{part}\n\n" end end when 'strong' From 2a0f4521e8638117cd3322b6cb0defbc0a4c3221 Mon Sep 17 00:00:00 2001 From: Ben Sheldon Date: Thu, 9 Jan 2014 15:31:31 -0800 Subject: [PATCH 3/3] add spec for multi-paragraph blockquotes --- spec/cases/html_page_spec.rb | 18 ++++++++++++++---- 1 file changed, 14 insertions(+), 4 deletions(-) diff --git a/spec/cases/html_page_spec.rb b/spec/cases/html_page_spec.rb index 235bb3b..5a59390 100644 --- a/spec/cases/html_page_spec.rb +++ b/spec/cases/html_page_spec.rb @@ -46,7 +46,7 @@ DIY的手绘行程图
55105222201110032253301023057594630_006.jpg -