From f2669327c9d7bf6c321c3091fc52a2deefebc2b9 Mon Sep 17 00:00:00 2001 From: "copilot-swe-agent[bot]" <198982749+Copilot@users.noreply.github.com> Date: Wed, 4 Mar 2026 00:37:23 +0000 Subject: [PATCH 1/2] Initial plan From f7eefc15c1a3f12cc59641f4e33757d1965d2415 Mon Sep 17 00:00:00 2001 From: "copilot-swe-agent[bot]" <198982749+Copilot@users.noreply.github.com> Date: Wed, 4 Mar 2026 01:34:57 +0000 Subject: [PATCH 2/2] test: add mock_ask_confirmation assertions to reset workflow tests Co-authored-by: amilcarlucas <24453563+amilcarlucas@users.noreply.github.com> --- tests/test_data_model_parameter_editor.py | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/tests/test_data_model_parameter_editor.py b/tests/test_data_model_parameter_editor.py index 262d1c47f..ca9117f08 100755 --- a/tests/test_data_model_parameter_editor.py +++ b/tests/test_data_model_parameter_editor.py @@ -602,6 +602,7 @@ def test_user_handles_parameter_upload_errors_gracefully(self, parameter_editor) # Assert: Errors handled via callback assert reset_required is False # No successful uploads assert len(uploaded_params) == 0 # No parameters were uploaded + mock_ask_confirmation.assert_not_called() mock_show_error.assert_called_once() error_call_args = mock_show_error.call_args[0] assert "Failed to set parameter" in error_call_args[1] # Second argument is the error message @@ -631,6 +632,7 @@ def test_user_uploads_sid_axis_from_zero_to_nonzero_triggers_possible_reset(self # Assert: Possible reset triggered and parameter uploaded assert reset_happened is True assert "SID_AXIS" in uploaded_params + mock_ask_confirmation.assert_called_once() mock_show_error.assert_not_called() def test_user_uploads_sid_axis_from_nonzero_to_different_nonzero_skips_reset(self, parameter_editor) -> None: @@ -659,6 +661,7 @@ def test_user_uploads_sid_axis_from_nonzero_to_different_nonzero_skips_reset(sel # to the normal upload path (not handled by this workflow) assert reset_happened is False assert "SID_AXIS" not in uploaded_params + mock_ask_confirmation.assert_not_called() mock_show_error.assert_not_called() def test_user_uploads_sid_axis_from_nonzero_to_zero_skips_reset(self, parameter_editor) -> None: @@ -686,6 +689,7 @@ def test_user_uploads_sid_axis_from_nonzero_to_zero_skips_reset(self, parameter_ # Assert: No reset triggered assert reset_happened is False assert "SID_AXIS" not in uploaded_params + mock_ask_confirmation.assert_not_called() mock_show_error.assert_not_called() def test_user_uploads_sid_axis_absent_from_fc_to_nonzero_triggers_possible_reset(self, parameter_editor) -> None: @@ -713,6 +717,7 @@ def test_user_uploads_sid_axis_absent_from_fc_to_nonzero_triggers_possible_reset # Assert: Possible reset triggered and parameter uploaded assert reset_happened is True assert "SID_AXIS" in uploaded_params + mock_ask_confirmation.assert_called_once() mock_show_error.assert_not_called()