GetQ3() returns Q1() instead of Q3() in SVIn/pose_graph/src/utils/Statistics.cpp?

[daetz-coder]

Hi there,

I was reviewing the code in SVIn/pose_graph/src/utils/Statistics.cpp and noticed a potential inconsistency in the implementation of Statistics::GetQ3(size_t handle). Currently, the function is implemented as follows:

double Statistics::GetQ3(size_t handle) {
  std::lock_guard<std::mutex> lock(Instance().mutex_);
  return Instance().stats_collectors_[handle].Q1();
}

Shouldn’t GetQ3() be returning Q3() instead of Q1()? This seems like it might be a copy-paste error. Could you please confirm whether this is intentional or if it should be corrected to:

double Statistics::GetQ3(size_t handle) {
  std::lock_guard<std::mutex> lock(Instance().mutex_);
  return Instance().stats_collectors_[handle].Q3();
}

Thank you for your time and for maintaining this project!

Best regards