ECS stats in TBC are off - they are counting talents twice.

[Spiritshroud08]

So if you look at these screenshots for example. I have 3% hit from frost tree talents for frost/fire spells. Taking all my gear off defualt blizzard stats says I have 0% hit. But ECS says i have 6% fire/frost hit bonus with a miss lvl + 3 of 11%.

Also if you see it says I have 14.67% fire crit.. when default blizz says 2.67% with no gear, if i hover over it says 8.67% with talents. The only crit talent i have is Critical Mass which is 6% crit. So it almost seems like ECS is doubling the benefits talents give. ECS is adding 12% crit from criticals mass's 6% and 6% hit from elemental precisions 3% benefit.

[Alessandro-Barbieri]

I pushed the hit fix here #402

[Alessandro-Barbieri]

I looked at how ecs calculates spell crit and now I have many questions ...
It needs a complete rework

[BreakBB]

I looked at how ecs calculates spell crit and now I have many questions ... It needs a complete rework

Feel free 😅 Many things in ECS are quite outdated and don't reflect API changes. But who am I telling that.

[Spiritshroud08]

I pushed the hit fix here #402

Apparently according to the mage discord, even though the elemental precision talent says 3% for frost / fire you still get 6% hit for frost spells from it. But only 3% for fire spells

[Alessandro-Barbieri]

I pushed the hit fix here #402

Apparently according to the mage discord, even though the elemental precision talent says 3% for frost / fire you still get 6% hit for frost spells from it. But only 3% for fire spells

I really doubt this is even true. ECS was showing 6% because that's the value for classic era.

[Alessandro-Barbieri]

I looked at how ecs calculates spell crit and now I have many questions ... It needs a complete rework

Feel free 😅 Many things in ECS are quite outdated and don't reflect API changes. But who am I telling that.

Spell crit changes will come in another PR

[Spiritshroud08]

I pushed the hit fix here #402

Apparently according to the mage discord, even though the elemental precision talent says 3% for frost / fire you still get 6% hit for frost spells from it. But only 3% for fire spells

I really doubt this is even true. ECS was showing 6% because that's the value for classic era.

No it is true. Can google it, it’s well known. I assumed it was wrong because it was using classic data. I was just letting you know because maybe you want to keep a 6% modifier for frost and just change fire to 3%

[Alessandro-Barbieri]

No it is true. Can google it, it’s well known. I assumed it was wrong because it was using classic data. I was just letting you know because maybe you want to keep a 6% modifier for frost and just change fire to 3%

since this bug is only affecting the frostbolt spell, it's correct to only show 3% for the general frost hit

[Spiritshroud08]

No it is true. Can google it, it’s well known. I assumed it was wrong because it was using classic data. I was just letting you know because maybe you want to keep a 6% modifier for frost and just change fire to 3%

since this bug is only affecting the frostbolt spell, it's correct to only show 3% for the general frost hit

oh ive heard it was all frost spells, frostbolt, blizz, CoC... the classic WoW Mage Discord explains it all

[Spiritshroud08]

No it is true. Can google it, it’s well known. I assumed it was wrong because it was using classic data. I was just letting you know because maybe you want to keep a 6% modifier for frost and just change fire to 3%

since this bug is only affecting the frostbolt spell, it's correct to only show 3% for the general frost hit

how do i get the fix?