[TBC Anniversary] Hit Rating Scope on Ranged weapon is counted twice

[bugeaggeorge]

Seems like the 30 Hit Rating (3% hit) enchant/scope on the ranged weapon is counted twice.

10 Hit Rating = 1% hit at level 60.

[BreakBB]

Looks like another case where Blizzard changed the API... In the past (issue #1) was exactly about this enchant NOT taken into account.

@bugeaggeorge can you run the following command with and without the crossbow equipped?

/dump GetCombatRatingBonus(CR_HIT_RANGED)

[bugeaggeorge]

@BreakBB

Equiped:

Not-equiped:

[BreakBB]

Thanks @bugeaggeorge

So @Alessandro-Barbieri for TBC we should not check for the range enchant for Hit.

[Alessandro-Barbieri]

#404 may fix the issue

[bugeaggeorge]

Ranged equipped with enchant:

Non-equipped ranged with enchant:

@BreakBB @Alessandro-Barbieri seems that PR #404 does fix it. I downloaded the branch code from that PR and used it to test it out. It also contains the fix for Draenei Heroic Presence 1% bonus for ranged from what I see.