From 107b2cab9e59eac824478a54e6ca302a42736425 Mon Sep 17 00:00:00 2001 From: Chris Date: Fri, 12 Feb 2021 11:48:28 +0000 Subject: [PATCH 1/2] Add PHP platform for 7.4 in composer.json and switch away from array_key_exists inside of HashToKeyValueArrayTransformer.php array_key_exists is deprecated for use on objects in php 7.4 (preparing for PHP 8). --- Form/DataTransformer/HashToKeyValueArrayTransformer.php | 2 +- composer.json | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/Form/DataTransformer/HashToKeyValueArrayTransformer.php b/Form/DataTransformer/HashToKeyValueArrayTransformer.php index e27894d..bddbd87 100644 --- a/Form/DataTransformer/HashToKeyValueArrayTransformer.php +++ b/Form/DataTransformer/HashToKeyValueArrayTransformer.php @@ -41,7 +41,7 @@ public function reverseTransform($value) throw new TransformationFailedException; } - if (array_key_exists($data['key'], $return)) { + if (isset($data['key'], $return)) { throw new TransformationFailedException('Duplicate key detected'); } diff --git a/composer.json b/composer.json index 17f15b3..bb38807 100644 --- a/composer.json +++ b/composer.json @@ -7,7 +7,7 @@ "psr-4": { "Burgov\\Bundle\\KeyValueFormBundle\\": "" } }, "require": { - "php": ">=5.3.3", + "php": ">=5.3.3|^7.4", "symfony/form": "^2.3|^3.0|^4.0|^5.0" }, "conflict": { From 355d78432fdd0f62ab1e69737ac736baa5b828e6 Mon Sep 17 00:00:00 2001 From: Chris Date: Fri, 12 Feb 2021 11:51:19 +0000 Subject: [PATCH 2/2] Add PHP platform for 7.4 in composer.json and switch away from array_key_exists inside of HashToKeyValueArrayTransformer.php array_key_exists is deprecated for use on objects in php 7.4 (preparing for PHP 8). --- Form/DataTransformer/HashToKeyValueArrayTransformer.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Form/DataTransformer/HashToKeyValueArrayTransformer.php b/Form/DataTransformer/HashToKeyValueArrayTransformer.php index bddbd87..1c91f08 100644 --- a/Form/DataTransformer/HashToKeyValueArrayTransformer.php +++ b/Form/DataTransformer/HashToKeyValueArrayTransformer.php @@ -41,7 +41,7 @@ public function reverseTransform($value) throw new TransformationFailedException; } - if (isset($data['key'], $return)) { + if (isset($data['key'], $return[$data['key']])) { throw new TransformationFailedException('Duplicate key detected'); }