Open
Conversation
aitorarjona
suggested changes
Oct 22, 2024
Contributor
There was a problem hiding this comment.
My idea here was to diferentiate object storage and file system depending on the path prefix. This way we can keep all the logic of CloudObject. For instance, s3://mybucket/myobject for S3 and fs://mybucket/myobject for file system. Then in the class setup we can choose the correct backend. To solve the root path for the FS backend, we can use the storage_config parameter, for example:
co = CloudObject("fs://mybucket/myfile", VCF, storage_config={"fs_root": "/tmp"})
would read myfile from /tmp/mybucket/myfile from the file system mounted on /tmp or /...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Initial implementation to use dataplug directly atop the file system. Bucket is a base directory, and all keys are relative to that directory.
Just
instead of
And use