-
Notifications
You must be signed in to change notification settings - Fork 16
Description
The init-cert-job.yaml & backfill-job template have inconsistent label handling compared to other job templates in the chart, and the values schema doesn't allow custom labels to be defined for this component.
Issues Identified:
- Inconsistent Label Generation Pattern: The
init-cert-job.yamlandbackfill-jobtemplate doesn't follow the same label generation pattern as other job templates:
-
helmless-job.yaml uses:
{{- include "cloudzero-agent.generateLabels" (dict "globals" . "component" "helmless" "labels" .Values.components.miscellaneous.helmless.labels) | nindent 2 }} -
config-loader-job.yaml:
{{- include "cloudzero-agent.generateLabels" (dict "globals" . "component" "config-loader" "labels" .Values.components.miscellaneous.configLoader.labels) | nindent 6 }} -
backfill-job.yaml only uses:
{{- include "cloudzero-agent.insightsController.initBackfillJob.matchLabels" $ | nindent 8 }}and doesn't leverage the generateLabels helper -
init-cert-job.yaml only uses:
{{- include "cloudzero-agent.insightsController.initCertJob.matchLabels" . | nindent 8 }}and doesn't leverage the generateLabels helper
- Missing Schema Definition for Template References for init-cert-job & backfill-job: The template uses
{{- include "cloudzero-agent.insightsController.initBackfillJob.matchLabels" $ | nindent 8 }}and{{- include "cloudzero-agent.insightsController.initCertJob.matchLabels" . | nindent 8 }}but there's no corresponding schema definition that would allow users to define these labels in values.yaml.
Team, could these be fix in next version