fix: only inline macros

Author: not-matthias

.vscode/settings.json

@@ -1,3 +1,10 @@
 {
-    "cmake.sourceDirectory": "/workspaces/codspeed-cpp/picobench"
-}
+    "cmake.sourceDirectory": "/workspaces/codspeed-cpp/picobench",
+    "files.associations": {
+        "*.ejs": "html",
+        "string": "cpp",
+        "chrono": "cpp",
+        "text_encoding": "cpp",
+        "typeinfo": "cpp"
+    }
+}

core/include/codspeed.h

@@ -18,8 +18,8 @@ class CodSpeed {
   // Member functions
   void push_group(const std::string &group);
   void pop_group();
-  void start_benchmark(const std::string &name);
-  void end_benchmark();
+  void start_benchmark(const std::string &name) __attribute__((noinline));
+  void end_benchmark() __attribute__((noinline));
 
  private:
   // Private constructor to prevent direct instantiation

core/include/measurement.hpp

@@ -46,20 +46,15 @@ inline void measurement_set_metadata() {
 }
 
 __attribute__((always_inline)) inline void measurement_start() {
-  instrument_hooks_start_benchmark(get_hooks());
-
   CALLGRIND_ZERO_STATS;
   CALLGRIND_START_INSTRUMENTATION;
 }
 
 __attribute__((always_inline)) inline void measurement_stop() {
   CALLGRIND_STOP_INSTRUMENTATION;
-
-  instrument_hooks_stop_benchmark(get_hooks());
 };
 
-__attribute__((noinline)) inline void measurement_set_executed(
-    const std::string& name) {
+inline void measurement_set_executed(const std::string& name) {
 #ifdef _WIN32
   auto current_pid = _getpid();
 #else

core/src/codspeed.cpp

@@ -69,7 +69,8 @@ void CodSpeed::pop_group() {
   }
 }
 
-void CodSpeed::start_benchmark(const std::string &name) {
+__attribute__((noinline)) void CodSpeed::start_benchmark(
+    const std::string &name) {
   std::string uri = name;
 
   uri = sanitize_bench_args(uri);
@@ -82,9 +83,11 @@ void CodSpeed::start_benchmark(const std::string &name) {
   }
 
   current_benchmark = uri;
+  instrument_hooks_start_benchmark(get_hooks());
 }
 
-void CodSpeed::end_benchmark() {
+__attribute__((noinline)) void CodSpeed::end_benchmark() {
+  instrument_hooks_stop_benchmark(get_hooks());
   measurement_set_executed(current_benchmark);
   benchmarked.push_back(current_benchmark);
   std::string action_str = is_instrumented ? "Measured" : "Checked";