From ea474e1ef33ab106672e262211587e2d2c3251d1 Mon Sep 17 00:00:00 2001 From: not-matthias Date: Mon, 25 Aug 2025 10:29:18 +0200 Subject: [PATCH 1/2] fix: dont show error when libpython is not found --- src/run/runner/valgrind/executor.rs | 2 -- src/run/runner/valgrind/helpers/venv_compat.sh | 4 ++-- 2 files changed, 2 insertions(+), 4 deletions(-) diff --git a/src/run/runner/valgrind/executor.rs b/src/run/runner/valgrind/executor.rs index 14321d3d..c5cc0a79 100644 --- a/src/run/runner/valgrind/executor.rs +++ b/src/run/runner/valgrind/executor.rs @@ -22,8 +22,6 @@ impl Executor for ValgrindExecutor { if let Err(error) = venv_compat::symlink_libpython(None) { error!("Failed to symlink libpython: {error}"); - } else { - info!("Successfully added symlink for libpython in the venv"); } Ok(()) diff --git a/src/run/runner/valgrind/helpers/venv_compat.sh b/src/run/runner/valgrind/helpers/venv_compat.sh index d671315f..fb5ac21e 100755 --- a/src/run/runner/valgrind/helpers/venv_compat.sh +++ b/src/run/runner/valgrind/helpers/venv_compat.sh @@ -6,7 +6,7 @@ function add_symlink() { system_python="$(readlink -f "$venv_python")" if [ -z "$system_python" ]; then echo "Error: Failed to resolve real path for $venv_python" >&2 - return 1 + return 0 fi system_path="$(dirname $(dirname "$system_python"))" @@ -17,7 +17,7 @@ function add_symlink() { libpython_name="$(ldd "$venv_python" 2>/dev/null | grep -o -m1 'libpython[^[:space:]]*' || true)" if [ -z "$libpython_name" ]; then echo "Error: exact libpython name not found in $(ldd $venv_python)" >&2 - return 1 + return 0 fi echo "Found linked libpython: $libpython_name" From 5c6d90addbaf4fc138512b830ccacd3cafbaa6a7 Mon Sep 17 00:00:00 2001 From: not-matthias Date: Mon, 25 Aug 2025 10:30:45 +0200 Subject: [PATCH 2/2] chore: change log level to warn for venv_compat error --- src/run/runner/valgrind/executor.rs | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/run/runner/valgrind/executor.rs b/src/run/runner/valgrind/executor.rs index c5cc0a79..13dbbd67 100644 --- a/src/run/runner/valgrind/executor.rs +++ b/src/run/runner/valgrind/executor.rs @@ -21,7 +21,8 @@ impl Executor for ValgrindExecutor { install_valgrind(system_info).await?; if let Err(error) = venv_compat::symlink_libpython(None) { - error!("Failed to symlink libpython: {error}"); + warn!("Failed to symlink libpython"); + debug!("Script error: {error}"); } Ok(())