From 09447f11b490887c4e548e5a19b0aea6e1c4a9b4 Mon Sep 17 00:00:00 2001 From: danc094codetogether Date: Wed, 26 Nov 2025 13:01:50 -0600 Subject: [PATCH 1/2] feat(helm): add warning log when deprecated AV settings are detected Fixes: #192 - Added a startup warning when any Audio/Video related values (av.enabled, av.serverIP, av.stunServers, av.jitsiUrl) are present in Helm chart configurations. - Ensures deployments are notified that built in A/V support is no longer available. - No functional behavior changed, only logs a warning at container start. --- charts/collab/templates/deployment.yaml | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/charts/collab/templates/deployment.yaml b/charts/collab/templates/deployment.yaml index ff2fde7..a4e77d8 100644 --- a/charts/collab/templates/deployment.yaml +++ b/charts/collab/templates/deployment.yaml @@ -110,6 +110,15 @@ spec: {{- if or (eq .Values.codetogether.mode "direct") (eq .Values.codetogether.mode "locator-edge") }} - name: CT_AV_ENABLED value: {{ .Values.av.enabled | quote }} + + # ------------------------------ + # A/V DEPRECATION NOTICE + # ------------------------------ + {{- if or .Values.av.enabled .Values.av.serverIP .Values.av.stunServers.enabled .Values.av.jitsiUrl }} + - name: CT_AV_DEPRECATED_WARNING + value: "Audio/Video options detected in Helm values, but A/V is no longer supported and will be ignored." + {{- end }} + {{- if .Values.av.enabled }} - name: CT_AV_LAN_IP value: {{ .Values.av.serverIP | quote }} From 5e740ff5d268d80a2ea96b13ba6effb3ff55af30 Mon Sep 17 00:00:00 2001 From: danc094codetogether Date: Fri, 28 Nov 2025 15:25:31 -0600 Subject: [PATCH 2/2] chore: add AV deprecation warning and clean up env vars - Add Helm NOTES warning when AV related values are configured - Remove unused CT_AV_DEPRECATED_WARNING environment variable from Deployment - Keep AV env configuration minimal while clearly signaling that A/V is no longer supported --- charts/collab/templates/NOTES.txt | 18 ++++++++++++++++++ charts/collab/templates/deployment.yaml | 8 -------- 2 files changed, 18 insertions(+), 8 deletions(-) diff --git a/charts/collab/templates/NOTES.txt b/charts/collab/templates/NOTES.txt index 8978eda..7944fec 100644 --- a/charts/collab/templates/NOTES.txt +++ b/charts/collab/templates/NOTES.txt @@ -3,3 +3,21 @@ Application URL: {{- $host := (urlParse .Values.codetogether.url).host }} http{{ if $.Values.ingress.tls }}s{{ end }}://{{ $host }}{{ .path }} {{- end }} + +{{- if or .Values.av.enabled .Values.av.serverIP .Values.av.stunServers.enabled .Values.av.jitsiUrl }} + +############################################################################### +# WARNING: A/V OPTIONS DEPRECATED +############################################################################### +Audio/Video options were detected in your Helm values: + + av.enabled = {{ .Values.av.enabled | default "false" }} + av.serverIP = {{ .Values.av.serverIP | default "" }} + av.stunServers.enabled = {{ .Values.av.stunServers.enabled | default "false" }} + av.jitsiUrl = {{ .Values.av.jitsiUrl | default "" }} + +A/V is no longer supported and these settings will be ignored by the server. +Please remove these values from your codetogether-values.yaml. +############################################################################### + +{{- end }} \ No newline at end of file diff --git a/charts/collab/templates/deployment.yaml b/charts/collab/templates/deployment.yaml index a4e77d8..8466fba 100644 --- a/charts/collab/templates/deployment.yaml +++ b/charts/collab/templates/deployment.yaml @@ -111,14 +111,6 @@ spec: - name: CT_AV_ENABLED value: {{ .Values.av.enabled | quote }} - # ------------------------------ - # A/V DEPRECATION NOTICE - # ------------------------------ - {{- if or .Values.av.enabled .Values.av.serverIP .Values.av.stunServers.enabled .Values.av.jitsiUrl }} - - name: CT_AV_DEPRECATED_WARNING - value: "Audio/Video options detected in Helm values, but A/V is no longer supported and will be ignored." - {{- end }} - {{- if .Values.av.enabled }} - name: CT_AV_LAN_IP value: {{ .Values.av.serverIP | quote }}