From 8b860bd316a85abd72a0b9350ba7ac2f2467fa65 Mon Sep 17 00:00:00 2001 From: Alaa Tagi Date: Tue, 4 Nov 2025 16:18:24 +0000 Subject: [PATCH 01/13] fix the implentation to run test for this function --- Sprint-1/fix/median.js | 28 ++++++++++++++++++++++++++-- 1 file changed, 26 insertions(+), 2 deletions(-) diff --git a/Sprint-1/fix/median.js b/Sprint-1/fix/median.js index b22590bc6..75db3aa5d 100644 --- a/Sprint-1/fix/median.js +++ b/Sprint-1/fix/median.js @@ -5,9 +5,33 @@ // Hint: Please consider scenarios when 'list' doesn't have numbers (the function is expected to return null) // or 'list' has mixed values (the function is expected to sort only numbers). + function calculateMedian(list) { - const middleIndex = Math.floor(list.length / 2); - const median = list.splice(middleIndex, 1)[0]; + if (!Array.isArray(list)) { + + return null; + } + // Filter out non-numeric values + const filteredList = list.filter(item => typeof item === 'number' && !isNaN(item)); + + // If there are no valid numbers, return null + if (filteredList.length === 0) { + return null; + } + + // Sort numerically (without modifying the original array) + const sortedList = filteredList.slice().sort((a, b) => a - b); + + // Compute the median + const midIndex = Math.floor(sortedList.length / 2); + let median; + + if (sortedList.length % 2 === 0) { + median = (sortedList[midIndex - 1] + sortedList[midIndex]) / 2; + } else { + median = sortedList[midIndex]; + } + return median; } From d0256bd0a4fe0fd4c9b9353ef8e802ae98095e47 Mon Sep 17 00:00:00 2001 From: Alaa Tagi Date: Tue, 4 Nov 2025 16:54:06 +0000 Subject: [PATCH 02/13] create deduplicate code --- Sprint-1/implement/dedupe.js | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/Sprint-1/implement/dedupe.js b/Sprint-1/implement/dedupe.js index 781e8718a..e78dabebc 100644 --- a/Sprint-1/implement/dedupe.js +++ b/Sprint-1/implement/dedupe.js @@ -1 +1,6 @@ -function dedupe() {} +function dedupe(arr) { + const deduplicatedArray = arr.filter((item, index) => arr.indexOf(item) === index); + return deduplicatedArray; +} + +module.exports = dedupe; \ No newline at end of file From 5be0b22947dd7e0689ccea0a5317d068c8cd474b Mon Sep 17 00:00:00 2001 From: Alaa Tagi Date: Tue, 4 Nov 2025 16:55:54 +0000 Subject: [PATCH 03/13] writing tests code for dedupe file --- Sprint-1/implement/dedupe.test.js | 28 +++++++++++++++++++++++++++- 1 file changed, 27 insertions(+), 1 deletion(-) diff --git a/Sprint-1/implement/dedupe.test.js b/Sprint-1/implement/dedupe.test.js index 23e0f8638..45f8b8ab1 100644 --- a/Sprint-1/implement/dedupe.test.js +++ b/Sprint-1/implement/dedupe.test.js @@ -16,12 +16,38 @@ E.g. dedupe([1, 2, 1]) target output: [1, 2] // Given an empty array // When passed to the dedupe function // Then it should return an empty array -test.todo("given an empty array, it returns an empty array"); +test("given an empty array, it returns an empty array", () => { + [ + {input:[], expected:[]} + ].forEach(({input, expected}) => { + const result = dedupe(input); + expect(result).toEqual(expected); + }); +}); // Given an array with no duplicates // When passed to the dedupe function // Then it should return a copy of the original array +test("given an array with no duplicates, it returns a copy of the original array", () => { + [ + {input:[1, 2, 3], expected:[1, 2, 3]}, + {input:['a', 'b', 'c'], expected:['a', 'b', 'c']} + ].forEach(({input, expected}) => { + const result = dedupe(input); + expect(result).toEqual(expected); + }); +}); // Given an array with strings or numbers // When passed to the dedupe function // Then it should remove the duplicate values, preserving the first occurence of each element +test("given an array with strings or numbers, it removes duplicate values preserving the first occurrence of each element", () => { + [ + {input:['a','a','a','b','b','c'], expected:['a','b','c']}, + {input:[5, 1, 1, 2, 3, 2, 5, 8], expected:[5, 1, 2, 3, 8]}, + {input:[1, 2, 1], expected:[1, 2]} + ].forEach(({input, expected}) => { + const result = dedupe(input); + expect(result).toEqual(expected); + }); +}); \ No newline at end of file From f4b089ec0b952893f918a12eb93ec47f90314734 Mon Sep 17 00:00:00 2001 From: Alaa Tagi Date: Tue, 4 Nov 2025 17:03:44 +0000 Subject: [PATCH 04/13] write a code to find a max element of an array --- Sprint-1/implement/max.js | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/Sprint-1/implement/max.js b/Sprint-1/implement/max.js index 6dd76378e..47184d2b6 100644 --- a/Sprint-1/implement/max.js +++ b/Sprint-1/implement/max.js @@ -1,4 +1,11 @@ function findMax(elements) { + let max = -Infinity; + for (let i = 0; i < elements.length; i++) { + if (elements[i] > max) { + max = elements[i]; + } + } + return max; } module.exports = findMax; From 5dca5376a372bbda9e1f5dbb2522aaed10a2bf5a Mon Sep 17 00:00:00 2001 From: Alaa Tagi Date: Tue, 4 Nov 2025 17:04:53 +0000 Subject: [PATCH 05/13] add tests for max file --- Sprint-1/implement/max.test.js | 36 +++++++++++++++++++++++++++++++++- 1 file changed, 35 insertions(+), 1 deletion(-) diff --git a/Sprint-1/implement/max.test.js b/Sprint-1/implement/max.test.js index 82f18fd88..3e29c463b 100644 --- a/Sprint-1/implement/max.test.js +++ b/Sprint-1/implement/max.test.js @@ -16,28 +16,62 @@ const findMax = require("./max.js"); // When passed to the max function // Then it should return -Infinity // Delete this test.todo and replace it with a test. -test.todo("given an empty array, returns -Infinity"); +test("given an empty array, returns -Infinity", () => { + expect(findMax([])).toBe(-Infinity); +}); // Given an array with one number // When passed to the max function // Then it should return that number + +test("given an array with one number, returns that number", () => { + expect(findMax([33])).toBe(33); +}); + +// Given an array with multiple positive numbers +// When passed to the max function +// Then it should return the largest number + +test("given an array with multiple positive numbers, returns the largest number", () => { + expect(findMax([10, 20, 30, 40, 50])).toBe(50); +}); // Given an array with both positive and negative numbers // When passed to the max function // Then it should return the largest number overall +test("given an array with both positive and negative numbers, returns the largest number overall", () => { + expect(findMax([-10, -20, 0, 10, 20])).toBe(20); +}); + // Given an array with just negative numbers // When passed to the max function // Then it should return the closest one to zero +test("given an array with just negative numbers, returns the closest one to zero", () => { + expect(findMax([-10, -20, -30])).toBe(-10); +}); + // Given an array with decimal numbers // When passed to the max function // Then it should return the largest decimal number +test("given an array with decimal numbers, returns the largest decimal number", () => { + expect(findMax([1.5, 2.5, 3.5, 2.9])).toBe(3.5); +}); + // Given an array with non-number values // When passed to the max function // Then it should return the max and ignore non-numeric values +test("given an array with non-number values, returns the max and ignores non-numeric values", () => { + expect(findMax(['hey', 10, 'hi', 60, 10])).toBe(60); +}); + // Given an array with only non-number values // When passed to the max function // Then it should return the least surprising value given how it behaves for all other inputs + +test("given an array with only non-number values, returns -Infinity", () => { + expect(findMax(['hey', 'hi', 'hello'])).toBe(-Infinity); +}); From e7b1bd9742954e0a35263baa124ebadd5695c1af Mon Sep 17 00:00:00 2001 From: Alaa Tagi Date: Sat, 8 Nov 2025 15:47:38 +0000 Subject: [PATCH 06/13] update test code --- Sprint-1/implement/max.test.js | 8 -------- 1 file changed, 8 deletions(-) diff --git a/Sprint-1/implement/max.test.js b/Sprint-1/implement/max.test.js index 3e29c463b..b7f7bfb96 100644 --- a/Sprint-1/implement/max.test.js +++ b/Sprint-1/implement/max.test.js @@ -28,14 +28,6 @@ test("given an array with one number, returns that number", () => { expect(findMax([33])).toBe(33); }); -// Given an array with multiple positive numbers -// When passed to the max function -// Then it should return the largest number - -test("given an array with multiple positive numbers, returns the largest number", () => { - expect(findMax([10, 20, 30, 40, 50])).toBe(50); -}); - // Given an array with both positive and negative numbers // When passed to the max function // Then it should return the largest number overall From 1fb0850d54dbd23f288081e3ba8f0efc87f3048e Mon Sep 17 00:00:00 2001 From: Alaa Tagi Date: Sat, 8 Nov 2025 15:51:33 +0000 Subject: [PATCH 07/13] write a sum function --- Sprint-1/implement/sum.js | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/Sprint-1/implement/sum.js b/Sprint-1/implement/sum.js index 9062aafe3..8638400f5 100644 --- a/Sprint-1/implement/sum.js +++ b/Sprint-1/implement/sum.js @@ -1,4 +1,11 @@ function sum(elements) { + let total = 0; + for (let i = 0; i < elements.length; i++) { + if (typeof elements[i] === "number") { + total += elements[i]; + } + } + return total; } module.exports = sum; From 19cf25455a0858342151430cb27cb9691eb213d2 Mon Sep 17 00:00:00 2001 From: Alaa Tagi Date: Sat, 8 Nov 2025 15:56:27 +0000 Subject: [PATCH 08/13] implement a function that sum numerical elements of an array with several tests --- Sprint-1/implement/sum.test.js | 24 +++++++++++++++++++++++- 1 file changed, 23 insertions(+), 1 deletion(-) diff --git a/Sprint-1/implement/sum.test.js b/Sprint-1/implement/sum.test.js index dd0a090ca..b771d4bb1 100644 --- a/Sprint-1/implement/sum.test.js +++ b/Sprint-1/implement/sum.test.js @@ -13,24 +13,46 @@ const sum = require("./sum.js"); // Given an empty array // When passed to the sum function // Then it should return 0 -test.todo("given an empty array, returns 0") +test("given an empty array, returns 0", () => { + expect(sum([])).toBe(0); +}); // Given an array with just one number // When passed to the sum function // Then it should return that number +test("given an array with just one number, returns that number", () => { + expect(sum([40])).toBe(40); +}); + // Given an array containing negative numbers // When passed to the sum function // Then it should still return the correct total sum +test("given an array containing negative numbers, returns the correct total sum", () => { + expect(sum([-10, -20, -30])).toBe(-60); +}); + // Given an array with decimal/float numbers // When passed to the sum function // Then it should return the correct total sum +test("given an array with decimal numbers, returns the correct total sum", () => { + expect(sum([1.5, 2.5, 3.5])).toBe(7.5); +}); + // Given an array containing non-number values // When passed to the sum function // Then it should ignore the non-numerical values and return the sum of the numerical elements +test("given an array containing non-number values, returns the correct total sum", () => { + expect(sum(['hey', 10, 'hi', 60, 10])).toBe(80); +}); + // Given an array with only non-number values // When passed to the sum function // Then it should return the least surprising value given how it behaves for all other inputs + +test("given an array with only non-number values, returns 0", () => { + expect(sum(['hey', 'hi', 'hello'])).toBe(0); +}); \ No newline at end of file From 8ffbf0c5b32647aa923382e8fda6db82305d9b83 Mon Sep 17 00:00:00 2001 From: Alaa Tagi Date: Sat, 8 Nov 2025 16:05:26 +0000 Subject: [PATCH 09/13] implement a function of includes to use for..of loop --- Sprint-1/refactor/includes.js | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/Sprint-1/refactor/includes.js b/Sprint-1/refactor/includes.js index 29dad81f0..6aeac0b5d 100644 --- a/Sprint-1/refactor/includes.js +++ b/Sprint-1/refactor/includes.js @@ -1,9 +1,8 @@ // Refactor the implementation of includes to use a for...of loop function includes(list, target) { - for (let index = 0; index < list.length; index++) { - const element = list[index]; - if (element === target) { + for (const item of list) { + if (item === target) { return true; } } From 7a249276b661c966c2861ee3c8492c7ab22d3741 Mon Sep 17 00:00:00 2001 From: Alaa Tagi Date: Sat, 29 Nov 2025 17:34:32 +0000 Subject: [PATCH 10/13] editing median function by ensuring to avoid making unnecessary clones and no mutation --- Sprint-1/fix/median.js | 30 ++++++++++++++---------------- 1 file changed, 14 insertions(+), 16 deletions(-) diff --git a/Sprint-1/fix/median.js b/Sprint-1/fix/median.js index 75db3aa5d..07d175c8e 100644 --- a/Sprint-1/fix/median.js +++ b/Sprint-1/fix/median.js @@ -8,31 +8,29 @@ function calculateMedian(list) { if (!Array.isArray(list)) { - return null; - } - // Filter out non-numeric values - const filteredList = list.filter(item => typeof item === 'number' && !isNaN(item)); + } + + // Filter non-numbers + const filteredList = list.filter( + (item) => typeof item === "number" && !isNaN(item) + ); - // If there are no valid numbers, return null if (filteredList.length === 0) { return null; } - // Sort numerically (without modifying the original array) - const sortedList = filteredList.slice().sort((a, b) => a - b); + // We can safely sort filteredList directly + filteredList.sort((a, b) => a - b); - // Compute the median - const midIndex = Math.floor(sortedList.length / 2); - let median; + const mid = Math.floor(filteredList.length / 2); - if (sortedList.length % 2 === 0) { - median = (sortedList[midIndex - 1] + sortedList[midIndex]) / 2; - } else { - median = sortedList[midIndex]; + if (filteredList.length % 2 === 0) { + return (filteredList[mid - 1] + filteredList[mid]) / 2; + } + else { + return filteredList[mid]; } - - return median; } module.exports = calculateMedian; From 82f0ed9e57feb935fe546bc08917aeccd1f2d641 Mon Sep 17 00:00:00 2001 From: Alaa Tagi Date: Sat, 29 Nov 2025 17:52:24 +0000 Subject: [PATCH 11/13] update the code to meet the requirements --- Sprint-1/implement/dedupe.js | 19 +++++++++--- Sprint-1/implement/dedupe.test.js | 50 ++++++++++++++++--------------- 2 files changed, 41 insertions(+), 28 deletions(-) diff --git a/Sprint-1/implement/dedupe.js b/Sprint-1/implement/dedupe.js index e78dabebc..f40a19245 100644 --- a/Sprint-1/implement/dedupe.js +++ b/Sprint-1/implement/dedupe.js @@ -1,6 +1,17 @@ function dedupe(arr) { - const deduplicatedArray = arr.filter((item, index) => arr.indexOf(item) === index); - return deduplicatedArray; + if (!Array.isArray(arr)) return null; + + const seen = new Set(); + const result = []; + + for (const item of arr) { + if (!seen.has(item)) { + seen.add(item); + result.push(item); + } + } + + return result; } - -module.exports = dedupe; \ No newline at end of file + +module.exports = dedupe; diff --git a/Sprint-1/implement/dedupe.test.js b/Sprint-1/implement/dedupe.test.js index 45f8b8ab1..900cb606a 100644 --- a/Sprint-1/implement/dedupe.test.js +++ b/Sprint-1/implement/dedupe.test.js @@ -16,38 +16,40 @@ E.g. dedupe([1, 2, 1]) target output: [1, 2] // Given an empty array // When passed to the dedupe function // Then it should return an empty array + test("given an empty array, it returns an empty array", () => { - [ - {input:[], expected:[]} - ].forEach(({input, expected}) => { - const result = dedupe(input); - expect(result).toEqual(expected); - }); + const input = []; + const result = dedupe(input); + + expect(result).toEqual([]); + expect(result).not.toBe(input); }); // Given an array with no duplicates -// When passed to the dedupe function -// Then it should return a copy of the original array +// when passed to the dedupe function +// Then should return a copy of the original array test("given an array with no duplicates, it returns a copy of the original array", () => { - [ - {input:[1, 2, 3], expected:[1, 2, 3]}, - {input:['a', 'b', 'c'], expected:['a', 'b', 'c']} - ].forEach(({input, expected}) => { - const result = dedupe(input); - expect(result).toEqual(expected); - }); + const input = [1, 2, 3]; + const result = dedupe(input); + + expect(result).toEqual([1, 2, 3]); + expect(result).not.toBe(input); }); // Given an array with strings or numbers -// When passed to the dedupe function -// Then it should remove the duplicate values, preserving the first occurence of each element -test("given an array with strings or numbers, it removes duplicate values preserving the first occurrence of each element", () => { - [ - {input:['a','a','a','b','b','c'], expected:['a','b','c']}, - {input:[5, 1, 1, 2, 3, 2, 5, 8], expected:[5, 1, 2, 3, 8]}, - {input:[1, 2, 1], expected:[1, 2]} - ].forEach(({input, expected}) => { +// when passed to the dedupe function +// Then it returns a new array that removes duplicates preserving the first occurrence. +test("given an array with strings or numbers, removes duplicates preserving the first occurrence", () => { + const cases = [ + { input: ['a','a','a','b','b','c'], expected: ['a','b','c'] }, + { input: [5, 1, 1, 2, 3, 2, 5, 8], expected: [5, 1, 2, 3, 8] }, + { input: [1, 2, 1], expected: [1, 2] } + ]; + + cases.forEach(({ input, expected }) => { const result = dedupe(input); + expect(result).toEqual(expected); + expect(result).not.toBe(input); }); -}); \ No newline at end of file +}); From e5876dbdae0ef8881c7cc283c7f95229596835d7 Mon Sep 17 00:00:00 2001 From: Alaa Tagi Date: Sat, 29 Nov 2025 18:01:54 +0000 Subject: [PATCH 12/13] fix the code --- Sprint-1/implement/max.js | 19 +++++++++++++------ 1 file changed, 13 insertions(+), 6 deletions(-) diff --git a/Sprint-1/implement/max.js b/Sprint-1/implement/max.js index 47184d2b6..57359d2f0 100644 --- a/Sprint-1/implement/max.js +++ b/Sprint-1/implement/max.js @@ -1,11 +1,18 @@ function findMax(elements) { - let max = -Infinity; - for (let i = 0; i < elements.length; i++) { - if (elements[i] > max) { - max = elements[i]; - } + let max = -Infinity; + + for (let i = 0; i < elements.length; i++) { + const value = elements[i]; + + // Only consider real finite numbers + if (typeof value === "number" && Number.isFinite(value)) { + if (value > max) { + max = value; + } } - return max; + } + + return max; } module.exports = findMax; From 0d9f96858ae7d9fd2a80e6328405f8983e322f43 Mon Sep 17 00:00:00 2001 From: Alaa Tagi Date: Sat, 29 Nov 2025 18:05:19 +0000 Subject: [PATCH 13/13] fix the code to pass all the tests in jest file --- Sprint-1/implement/sum.js | 19 +++++++++++++------ 1 file changed, 13 insertions(+), 6 deletions(-) diff --git a/Sprint-1/implement/sum.js b/Sprint-1/implement/sum.js index 8638400f5..a77232ff2 100644 --- a/Sprint-1/implement/sum.js +++ b/Sprint-1/implement/sum.js @@ -1,11 +1,18 @@ function sum(elements) { - let total = 0; - for (let i = 0; i < elements.length; i++) { - if (typeof elements[i] === "number") { - total += elements[i]; - } + // Validate input + if (!Array.isArray(elements)) { + return 0; + } + + // Keep only valid finite numbers and accumulate them + let total = 0; + for (let i = 0; i < elements.length; i++) { + if (Number.isFinite(elements[i])) { + total += elements[i]; } - return total; + } + + return total; } module.exports = sum;