Skip to content

Todo list exercise has people create not amazing HTML #1289

@illicitonion

Description

@illicitonion

In https://github.com/CodeYourFuture/Module-Data-Groups/blob/main/Sprint-3/todo-list/README.md#instructions we instruct people to create buttons using this HTML:

<i class="fa fa-check" aria-hidden="true"></i>
<i class="fa fa-trash" aria-hidden="true"></i>

This seems not amazing - <i> is not a very semantic tag for a button, and setting aria-hidden I believe means that screen-readers will not expose to their users the ability to mark to do items as done or deleted?

These feel like bad habits to be teaching people...

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    Status

    ✅ Done

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions