-
-
Notifications
You must be signed in to change notification settings - Fork 123
Closed
Description
In https://github.com/CodeYourFuture/Module-Data-Groups/blob/main/Sprint-3/todo-list/README.md#instructions we instruct people to create buttons using this HTML:
<i class="fa fa-check" aria-hidden="true"></i>
<i class="fa fa-trash" aria-hidden="true"></i>
This seems not amazing - <i> is not a very semantic tag for a button, and setting aria-hidden I believe means that screen-readers will not expose to their users the ability to mark to do items as done or deleted?
These feel like bad habits to be teaching people...
mattg95
Metadata
Metadata
Assignees
Labels
No labels
Type
Projects
Status
✅ Done