-
Notifications
You must be signed in to change notification settings - Fork 4
Description
Great work on this project! I successfully reproduced dart-gui in our internal environment without using Docker, which was a great learning experience. During the process, I came across a few issues that I'd like to share, hoping they might be helpful for further improvements.
-
Logger redirection conflict: The log redirection in logger.py seems to conflict with the logger redirection of some providers. It might be worth revisiting the implementation to avoid this interference.
-
Missing task_loader.py in automation scripts: The automation scripts do not include task_loader.py, but I found that a preprocessing step using it is actually required for the run to work. Adding it to the automation flow would make the reproduction smoother.
-
High coupling with run_id and lack of debug output when rollout examples are missing: The project appears to be quite tightly coupled with run_id, which can make it less flexible. Additionally, when the training script fails to read rollout examples, it just hangs without any output. Adding some debug information in such cases would greatly help users identify and resolve the issue quickly.
Thank you again for the amazing work! I hope these observations are useful. Let me know if you need any more details from my side.