Syncing is done solely as user workflow and not as the logged in user

[blackappsolutions]

Bug-Description
When doing the content-sync, the appropriate workflow should behave as Publication or Translastion-workflows and putting in the logged in user who has initiated the content-sync as an editor to the affected resources.

To Reproduce

1. Execute a content-sync
2. Look at the synced resources
3. You will find not your user there but user "workflow"

Expected behavior
Own user should be the editor.

[blackappsolutions]

@stefanpieper / @cmfgi: Could you give is some insights here?

[nchieffo]

I may have a partial solution, remaining problem is that "My Edited Content" does not populate after running the workflow

look ad this patch:

Index: modules/extensions/coremedia-content-sync/workflow-server/src/main/java/com/coremedia/blueprint/contentsync/workflow/action/CreateAndLinkContents.java
IDEA additional info:
Subsystem: com.intellij.openapi.diff.impl.patch.CharsetEP
<+>UTF-8
===================================================================
diff --git a/modules/extensions/coremedia-content-sync/workflow-server/src/main/java/com/coremedia/blueprint/contentsync/workflow/action/CreateAndLinkContents.java b/modules/extensions/coremedia-content-sync/workflow-server/src/main/java/com/coremedia/blueprint/contentsync/workflow/action/CreateAndLinkContents.java
--- a/modules/extensions/coremedia-content-sync/workflow-server/src/main/java/com/coremedia/blueprint/contentsync/workflow/action/CreateAndLinkContents.java	(revision 3863028e6e8a04adeffd222f8b7b4a77f401520d)
+++ b/modules/extensions/coremedia-content-sync/workflow-server/src/main/java/com/coremedia/blueprint/contentsync/workflow/action/CreateAndLinkContents.java	(date 1621427766758)
@@ -7,8 +7,11 @@
 import com.coremedia.blueprint.contentsync.client.services.IAPIRepository;
 import com.coremedia.blueprint.contentsync.workflow.exception.ContentTypeMismatchException;
 import com.coremedia.blueprint.contentsync.workflow.property.PropertyMapper;
+import com.coremedia.cap.common.CapConnection;
+import com.coremedia.cap.common.CapSession;
 import com.coremedia.cap.content.Content;
 import com.coremedia.cap.content.ContentRepository;
+import com.coremedia.cap.user.User;
 import com.coremedia.cap.workflow.Process;
 import com.coremedia.cap.workflow.Task;
 import com.coremedia.workflow.common.util.SpringAwareLongAction;
@@ -80,7 +83,9 @@
     Process process = task.getContainingProcess();
     return new ActionParameters(getNumericIds(process.getList(getRemoteSyncIdsVariable())),
             process.getString(getEnvironmentVariable()),
-            process.getString(getTokenVariable()));
+            process.getString(getTokenVariable()),
+            process.getOwner()
+            );
   }
 
   @Override
@@ -91,34 +96,41 @@
 
     LOG.debug("starting sync with remote ids {} on environment {}", parameters.remoteSyncIds, parameters.environment);
 
-    ContentRepository repository = getConnection().getContentRepository();
+    CapConnection connection = getConnection();
+    CapSession session = connection.login(parameters.user);
+    try {
+      session.activate();
+      ContentRepository repository = session.getConnection().getContentRepository();
 
-    // map from remote numeric content ids to remote contents
-    Map<String, ContentDataModel> remoteContents = new HashMap<>();
-    // map from remote numeric content ids to local numeric content ids
-    Map<String, String> idMap = new HashMap<>();
+      // map from remote numeric content ids to remote contents
+      Map<String, ContentDataModel> remoteContents = new HashMap<>();
+      // map from remote numeric content ids to local numeric content ids
+      Map<String, String> idMap = new HashMap<>();
 
-    // 1st phase: process remote sync ids and store list of remote sync ids with references that can only be satisfied
-    // with given or yet-to-be-sync'd local content in 2nd phase
-    LOG.debug("sync 1st phase with ids {}", parameters.remoteSyncIds);
-    List<String> remoteSyncIdsRedo = processRemoteIds(parameters.remoteSyncIds,
-            remoteContents, idMap, repository, parameters.remoteRepository);
+      // 1st phase: process remote sync ids and store list of remote sync ids with references that can only be satisfied
+      // with given or yet-to-be-sync'd local content in 2nd phase
+      LOG.debug("sync 1st phase with ids {}", parameters.remoteSyncIds);
+      List<String> remoteSyncIdsRedo = processRemoteIds(parameters.remoteSyncIds,
+              remoteContents, idMap, repository, parameters.remoteRepository);
 
-    // 2nd phase: re-process remote sync ids with (yet) unsatisfied links that can be resolved now with all remote
-    // contents in place locally
-    LOG.debug("sync 2nd phase with ids {}", remoteSyncIdsRedo);
-    processRemoteIds(remoteSyncIdsRedo, remoteContents, idMap, repository, parameters.remoteRepository);
+      // 2nd phase: re-process remote sync ids with (yet) unsatisfied links that can be resolved now with all remote
+      // contents in place locally
+      LOG.debug("sync 2nd phase with ids {}", remoteSyncIdsRedo);
+      processRemoteIds(remoteSyncIdsRedo, remoteContents, idMap, repository, parameters.remoteRepository);
 
-    // check in all (potentially) checked-out local contents
-    for (String localId : idMap.values()) {
-      Content localContent = repository.getContent(localId);
-      if (localContent.isCheckedOut()) {
-        localContent.checkIn();
-      }
-    }
+      // check in all (potentially) checked-out local contents
+      for (String localId : idMap.values()) {
+        Content localContent = repository.getContent(localId);
+        if (localContent.isCheckedOut()) {
+          localContent.checkIn();
+        }
+      }
 
-    LOG.debug("finished sync");
-    return null;
+      LOG.debug("finished sync");
+      return null;
+    } finally {
+      session.close();
+    }
   }
 
   /**
@@ -331,22 +343,25 @@
     final List<String> remoteSyncIds;
     final String environment;
     final String token;
+    final User user;
     final IAPIRepository remoteRepository;
 
-    ActionParameters(List<String> remoteSyncIds, String environment, String token) {
+    ActionParameters(List<String> remoteSyncIds, String environment, String token, User user) {
       this.remoteSyncIds = remoteSyncIds;
       this.environment = environment;
       this.token = token;
+      this.user = user;
       remoteRepository = IAPIContext.withHostAndToken(environment, token).build().getRepository();
     }
 
     /**
      * Constructor for test purposes.
      */
-    ActionParameters(List<String> remoteSyncIds, String environment, String token, IAPIRepository remoteRepository) {
+    ActionParameters(List<String> remoteSyncIds, String environment, String token, User user, IAPIRepository remoteRepository) {
       this.remoteSyncIds = remoteSyncIds;
       this.environment = environment;
       this.token = token;
+      this.user = user;
       this.remoteRepository = remoteRepository;
     }
   }

[nchieffo]

@cmfgi do you have some suggestion on how to add all these content into the My Edited Content area?

[cmfgi]

Need to have a look to the implementation on how such contents are resolved. Will let you know once I have more information

[nchieffo]

Never mind, I understood why I was not seing my edited content populated: the user-changes app was not running at all

[cmfgi]

Will fix that issue