Skip to content

Commit 8936d83

Browse files
echobtfactorydroid
andauthored
fix(settings): add showLineNumbers to SearchSettings and fix activityBarPosition reference (#343)
- Add showLineNumbers property to SearchSettings interface with default value true - Fix MenuBar.tsx using activityBarLocation instead of activityBarPosition - These changes prevent TypeScript errors and ensure settings components remain functional Co-authored-by: Droid Agent <droid@factory.ai>
1 parent 96b3a5d commit 8936d83

File tree

2 files changed

+5
-2
lines changed

2 files changed

+5
-2
lines changed

cortex-gui/src/components/MenuBar.tsx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -225,12 +225,12 @@ export function MenuBar(props: MenuBarProps = {}) {
225225
}
226226

227227
// Settings accessors
228-
const activityBarLocation = () => settingsCtx?.effectiveSettings().theme.activityBarLocation || "side";
228+
const activityBarLocation = () => settingsCtx?.effectiveSettings().theme.activityBarPosition || "side";
229229
const menuBarVisibility = () => settingsCtx?.effectiveSettings().theme.menuBarVisibility || "classic";
230230

231231
// Handlers for changing settings
232232
const setActivityBarLocation = async (location: ActivityBarLocation) => {
233-
await settingsCtx?.updateThemeSetting("activityBarLocation", location);
233+
await settingsCtx?.updateThemeSetting("activityBarPosition", location);
234234
closeMenu();
235235
};
236236

cortex-gui/src/context/SettingsContext.tsx

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -289,6 +289,8 @@ export interface SearchSettings {
289289
useGlobalIgnoreFiles: boolean;
290290
followSymlinks: boolean;
291291
contextLines: number;
292+
/** Show line numbers in search results */
293+
showLineNumbers: boolean;
292294
}
293295

294296
/** JavaScript debug settings */
@@ -768,6 +770,7 @@ const DEFAULT_SEARCH: SearchSettings = {
768770
useGlobalIgnoreFiles: true,
769771
followSymlinks: true,
770772
contextLines: 2,
773+
showLineNumbers: true,
771774
};
772775

773776
const DEFAULT_VARIABLE_VISUALIZERS: VariableVisualizerSettings = {

0 commit comments

Comments
 (0)