From f98323c2b0a50fb6a8616b069f3d883f4c0e2dd3 Mon Sep 17 00:00:00 2001 From: Blotz Date: Fri, 29 Apr 2022 14:50:42 +0100 Subject: [PATCH 1/3] Modified edit_message to append edited massages to the queue --- discord/ext/test/backend.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/discord/ext/test/backend.py b/discord/ext/test/backend.py index 1934088..fc7097c 100644 --- a/discord/ext/test/backend.py +++ b/discord/ext/test/backend.py @@ -236,7 +236,7 @@ async def edit_message(self, channel_id: int, message_id: int, **fields: typing. locs = _get_higher_locs(1) message = locs.get("self", None) - await callbacks.dispatch_event("edit_message", message.channel, message, fields) + await callbacks.dispatch_event("send_message", message.channel, message, fields) out = facts.dict_from_message(message) out.update(fields) From 3616f65a28d4fdfa455fb885e0e38baabf17568d Mon Sep 17 00:00:00 2001 From: Blotz Date: Fri, 29 Apr 2022 14:51:34 +0100 Subject: [PATCH 2/3] Added test files to test whether edited messages are stored in queue --- tests/internal/cogs/edit.py | 21 +++++++++++++++++++++ tests/test_edit_cog.py | 24 ++++++++++++++++++++++++ 2 files changed, 45 insertions(+) create mode 100644 tests/internal/cogs/edit.py create mode 100644 tests/test_edit_cog.py diff --git a/tests/internal/cogs/edit.py b/tests/internal/cogs/edit.py new file mode 100644 index 0000000..64337b7 --- /dev/null +++ b/tests/internal/cogs/edit.py @@ -0,0 +1,21 @@ +from discord.ext.commands import Cog, command +from asyncio import sleep + + +class Edit(Cog): + + # Silence the default on_error handler + async def cog_command_error(self, ctx, error): + pass + + @command() + async def edit(self, ctx, text: str): + msg = await ctx.send(text) + print("Something") + reversed = text[::-1] + response = await msg.edit(content=reversed) # reverse the output of the command + + + +def setup(bot): + bot.add_cog(Edit()) diff --git a/tests/test_edit_cog.py b/tests/test_edit_cog.py new file mode 100644 index 0000000..674d341 --- /dev/null +++ b/tests/test_edit_cog.py @@ -0,0 +1,24 @@ + +import pytest +import discord.ext.test as test + +@pytest.mark.asyncio +async def test_edit(bot): + guild = bot.guilds[0] + channel = guild.channels[0] + + mes = await channel.send("Test Message") + await mes.edit(content="New Message") + + assert mes.content == "New Message" + +@pytest.mark.asyncio +@pytest.mark.cogs("cogs.edit") +async def test_edit_cog(bot): + guild = bot.guilds[0] + member = guild.members[0] + dm = await member.create_dm() + await test.message("!edit Ah-Ha!", dm) + + assert test.verify().message().content("Ah-Ha!") + assert test.verify().message().content("!aH-hA") From 027f2da09d2bbf8958dce6d7d52a8dabcc0a8f9e Mon Sep 17 00:00:00 2001 From: Blotz <55319277+Blotz@users.noreply.github.com> Date: Fri, 27 May 2022 00:41:01 +0100 Subject: [PATCH 3/3] Found mistake in PR Accidentally didnt save some final changes to file when creating PR --- discord/ext/test/backend.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/discord/ext/test/backend.py b/discord/ext/test/backend.py index fc7097c..f1fb375 100644 --- a/discord/ext/test/backend.py +++ b/discord/ext/test/backend.py @@ -236,7 +236,7 @@ async def edit_message(self, channel_id: int, message_id: int, **fields: typing. locs = _get_higher_locs(1) message = locs.get("self", None) - await callbacks.dispatch_event("send_message", message.channel, message, fields) + await callbacks.dispatch_event("send_message", message) out = facts.dict_from_message(message) out.update(fields)