From 386b4824d8b2ca0233411de0f4c9678c054138b4 Mon Sep 17 00:00:00 2001 From: pedro-bruno-cc Date: Wed, 5 Feb 2025 14:49:54 +0100 Subject: [PATCH 1/5] WAL-3164: Remove "reason" as filter for transactions/find --- src/main/java/com/currencycloud/client/CurrencyCloud.java | 1 - 1 file changed, 1 deletion(-) diff --git a/src/main/java/com/currencycloud/client/CurrencyCloud.java b/src/main/java/com/currencycloud/client/CurrencyCloud.java index 5be1778b..e6f44002 100644 --- a/src/main/java/com/currencycloud/client/CurrencyCloud.java +++ b/src/main/java/com/currencycloud/client/CurrencyCloud.java @@ -1468,7 +1468,6 @@ Transactions findTransactions( @Nullable @QueryParam("related_entity_short_reference") String relatedEntityShortReference, @Nullable @QueryParam("status") String status, @Nullable @QueryParam("type") String type, - @Nullable @QueryParam("reason") String reason, @Nullable @QueryParam("settles_at_from") java.sql.Date settlesAtFrom, @Nullable @QueryParam("settles_at_to") java.sql.Date settlesAtTo, @Nullable @QueryParam("created_at_from") java.sql.Date createdAtFrom, From 82c904e3ca38ff93b6336b0e9f41479b1945f452 Mon Sep 17 00:00:00 2001 From: pedro-bruno-cc Date: Fri, 7 Feb 2025 10:14:19 +0100 Subject: [PATCH 2/5] WAL-3164: Remove reference from Client --- src/main/java/com/currencycloud/client/CurrencyCloudClient.java | 1 - 1 file changed, 1 deletion(-) diff --git a/src/main/java/com/currencycloud/client/CurrencyCloudClient.java b/src/main/java/com/currencycloud/client/CurrencyCloudClient.java index b771d67a..cd294ad8 100644 --- a/src/main/java/com/currencycloud/client/CurrencyCloudClient.java +++ b/src/main/java/com/currencycloud/client/CurrencyCloudClient.java @@ -1437,7 +1437,6 @@ public Transactions findTransactions(@Nullable Transaction transaction, @Nullabl transaction.getRelatedEntityShortReference(), transaction.getStatus(), transaction.getType(), - transaction.getReason(), dateOnly(transaction.getSettlesAtFrom()), dateOnly(transaction.getSettlesAtTo()), dateOnly(transaction.getCreatedAtFrom()), From ef6bd6bca9fe002efd56d7125fe8a4b5d6e0cff9 Mon Sep 17 00:00:00 2001 From: pedro-bruno-cc Date: Tue, 18 Feb 2025 15:16:33 +0100 Subject: [PATCH 3/5] Revert "WAL-3164: Remove reference from Client" This reverts commit 82c904e3ca38ff93b6336b0e9f41479b1945f452. --- src/main/java/com/currencycloud/client/CurrencyCloudClient.java | 1 + 1 file changed, 1 insertion(+) diff --git a/src/main/java/com/currencycloud/client/CurrencyCloudClient.java b/src/main/java/com/currencycloud/client/CurrencyCloudClient.java index cd294ad8..b771d67a 100644 --- a/src/main/java/com/currencycloud/client/CurrencyCloudClient.java +++ b/src/main/java/com/currencycloud/client/CurrencyCloudClient.java @@ -1437,6 +1437,7 @@ public Transactions findTransactions(@Nullable Transaction transaction, @Nullabl transaction.getRelatedEntityShortReference(), transaction.getStatus(), transaction.getType(), + transaction.getReason(), dateOnly(transaction.getSettlesAtFrom()), dateOnly(transaction.getSettlesAtTo()), dateOnly(transaction.getCreatedAtFrom()), From e526581e677fc67a26953bdbebb7d265d6788508 Mon Sep 17 00:00:00 2001 From: pedro-bruno-cc Date: Tue, 18 Feb 2025 15:16:47 +0100 Subject: [PATCH 4/5] Revert "WAL-3164: Remove "reason" as filter for transactions/find" This reverts commit 386b4824d8b2ca0233411de0f4c9678c054138b4. --- src/main/java/com/currencycloud/client/CurrencyCloud.java | 1 + 1 file changed, 1 insertion(+) diff --git a/src/main/java/com/currencycloud/client/CurrencyCloud.java b/src/main/java/com/currencycloud/client/CurrencyCloud.java index e6f44002..5be1778b 100644 --- a/src/main/java/com/currencycloud/client/CurrencyCloud.java +++ b/src/main/java/com/currencycloud/client/CurrencyCloud.java @@ -1468,6 +1468,7 @@ Transactions findTransactions( @Nullable @QueryParam("related_entity_short_reference") String relatedEntityShortReference, @Nullable @QueryParam("status") String status, @Nullable @QueryParam("type") String type, + @Nullable @QueryParam("reason") String reason, @Nullable @QueryParam("settles_at_from") java.sql.Date settlesAtFrom, @Nullable @QueryParam("settles_at_to") java.sql.Date settlesAtTo, @Nullable @QueryParam("created_at_from") java.sql.Date createdAtFrom, From 2529dd1ec66850330f63016d115c850c2916e730 Mon Sep 17 00:00:00 2001 From: pedro-bruno-cc Date: Tue, 18 Feb 2025 15:19:12 +0100 Subject: [PATCH 5/5] WAL-3164: Mark as deprecated the "reason" as filter for transactions/find --- src/main/java/com/currencycloud/client/CurrencyCloud.java | 2 +- src/main/java/com/currencycloud/client/CurrencyCloudClient.java | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/main/java/com/currencycloud/client/CurrencyCloud.java b/src/main/java/com/currencycloud/client/CurrencyCloud.java index 5be1778b..2cf234a5 100644 --- a/src/main/java/com/currencycloud/client/CurrencyCloud.java +++ b/src/main/java/com/currencycloud/client/CurrencyCloud.java @@ -1468,7 +1468,7 @@ Transactions findTransactions( @Nullable @QueryParam("related_entity_short_reference") String relatedEntityShortReference, @Nullable @QueryParam("status") String status, @Nullable @QueryParam("type") String type, - @Nullable @QueryParam("reason") String reason, + @Deprecated @Nullable @QueryParam("reason") String reason, @Nullable @QueryParam("settles_at_from") java.sql.Date settlesAtFrom, @Nullable @QueryParam("settles_at_to") java.sql.Date settlesAtTo, @Nullable @QueryParam("created_at_from") java.sql.Date createdAtFrom, diff --git a/src/main/java/com/currencycloud/client/CurrencyCloudClient.java b/src/main/java/com/currencycloud/client/CurrencyCloudClient.java index b771d67a..7a00eb1c 100644 --- a/src/main/java/com/currencycloud/client/CurrencyCloudClient.java +++ b/src/main/java/com/currencycloud/client/CurrencyCloudClient.java @@ -1437,7 +1437,7 @@ public Transactions findTransactions(@Nullable Transaction transaction, @Nullabl transaction.getRelatedEntityShortReference(), transaction.getStatus(), transaction.getType(), - transaction.getReason(), + transaction.getReason(), /* Deprecated */ dateOnly(transaction.getSettlesAtFrom()), dateOnly(transaction.getSettlesAtTo()), dateOnly(transaction.getCreatedAtFrom()),