[BUG] Revelation Not Updating Client-Side After Revoke

[maikotui]

Describe the bug
I've got an issue where a revealed item does not "unreveal" after the advancement is revoked. Specifically, this is occurring while using Origins to set an advancement. Then, when a player changes their origin, they will still be able to use the item that was revealed. This lasts until the user reconnects. I found a solution in my custom modpack, I'm guessing there is a better way to fix it than just adding this mixin.

@Inject(at=@At(value = "INVOKE", target = "Lnet/minecraft/advancement/PlayerAdvancementTracker;onStatusUpdate(Lnet/minecraft/advancement/Advancement;)V"), method = "revokeCriterion(Lnet/minecraft/advancement/Advancement;Ljava/lang/String;)Z")
    private void revokeCriterion(Advancement advancement, String criterionName, CallbackInfoReturnable<Boolean> cir) {
        ClientRevelationHolder.processRemovedAdvancements(new HashSet<>(Collections.singletonList(advancement.getId())));
    }

[maikotui]

Actually, I'm now realizing that this might not be a complete fix lol. Doing some testing then will update the bug report.

[maikotui]

Yeah, this probably needs to be tested in a multiplayer environment. It works for singleplayer, but I doubt it will online.