-
Notifications
You must be signed in to change notification settings - Fork 84
Open
Description
Currently, the code does not resolve domain names for UDP transport:
php-datadogstatsd/src/DogStatsd.php
Lines 295 to 302 in def70c3
| public function flush($udp_message) | |
| { | |
| // Non - Blocking UDP I/O - Use IP Addresses! | |
| $socket = socket_create(AF_INET, SOCK_DGRAM, SOL_UDP); | |
| socket_set_nonblock($socket); | |
| socket_sendto($socket, $udp_message, strlen($udp_message), 0, $this->host, $this->port); | |
| socket_close($socket); | |
| } |
I understand the need (keep this entirely non-blocking), but was wondering what would be the right approach for this to be added (willing to file a PR, but want to make sure it can be merged before I go ahead).
/cc @jitendra-1217
jitendra-1217
Metadata
Metadata
Assignees
Labels
No labels