Skip to content

Item description methods are too complicated #25

@DavidFidge

Description

@DavidFidge

Item description methods have become too complicated to work with. They deal with long descriptions, short descriptions for inventory, prefixes and suffixes, whether an item is discovered and if discovered, whether the enchantment level is known. Ideas to address this:

  • Rather than trying to adhere to Don't Repeat Yourself, it may be a lot clearer to just copy and paste description code across concrete classes, or only have non-tokenised static strings that can be reused in the base class.
  • Still go with a DRY solution but rewrite all the code.

Also, the item type discovery system does work but it feels a bit difficult to work with sometimes.

Will decide on an approach as I add more items into the game. Leaning towards first idea due to its straightforwardness and simplicity.

Metadata

Metadata

Assignees

No one assigned

    Labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions