-
Notifications
You must be signed in to change notification settings - Fork 1
Open
Labels
automateddocumentationImprovements or additions to documentationImprovements or additions to documentation
Description
Documentation Update Needed
Commit: b7c195e
Commit Message: fix: Update ArgoCD notifications configuration for context variables
What Changed
This commit introduces breaking changes to the ArgoCD notifications configuration structure:
-
Configuration Structure Change:
- Before: Flat fields
cluster-nameandresource-groupin the ConfigMap - After: Nested
contextobject containingclusterNameandresourceGroup
- Before: Flat fields
-
Setup Script Update:
- Modified
setup-cluster-name.shto patch ConfigMap with new nested structure - Changed from:
{"data":{"cluster-name":"...","resource-group":"..."}} - Changed to:
{"data":{"context":"clusterName: ...\nresourceGroup: ...\n"}}
- Modified
-
Template Variable Syntax:
- Changed from:
$cluster-nameand$resource-group - Changed to:
{{.context.clusterName}}and{{.context.resourceGroup}}
- Changed from:
-
Safety Improvements:
- Added nil checks to triggers:
app.status.operationState != nil && - Prevents errors when status objects are not yet populated
- Added nil checks to triggers:
Documentation Files to Update
Priority 1: Act-3/SETUP.md
- Section "Configure Cluster Name Context" (lines ~35-45) needs to be updated
- Current documentation shows the old flat structure
- Need to update the
kubectl patchcommand example to use the new nested context format - Update all references from
clusterNametocontext.clusterName
Priority 2: Act-3/README.md
- Review and update any ArgoCD notifications configuration examples
- Ensure variable reference syntax is updated to use
{{.context.*}}format
Migration Notes Required
Users upgrading from the previous version need to:
- Re-run the
setup-cluster-name.shscript to migrate to the new format - Or manually patch their ConfigMap with the new structure:
kubectl patch configmap argocd-notifications-cm -n argocd \ -p '{"data":{"context":"clusterName: YOUR_CLUSTER\nresourceGroup: YOUR_RG\n"}}' - Restart the notifications controller after the change
Breaking Changes Alert
This issue was automatically created by analyzing commit b7c195e
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
automateddocumentationImprovements or additions to documentationImprovements or additions to documentation