From 46b22cf5a363d2f154f116a46099c798ea0510b5 Mon Sep 17 00:00:00 2001 From: "copilot-swe-agent[bot]" <198982749+Copilot@users.noreply.github.com> Date: Tue, 13 Jan 2026 20:53:48 +0000 Subject: [PATCH 1/4] Initial plan From 90fdb718f5f766e2cd895476ab6a30d598448383 Mon Sep 17 00:00:00 2001 From: "copilot-swe-agent[bot]" <198982749+Copilot@users.noreply.github.com> Date: Tue, 13 Jan 2026 20:58:52 +0000 Subject: [PATCH 2/4] fix(testsuite): use return value from assert_cmd assert() call The assert_cmd 2.1.2 update introduced a requirement to use the return value from the assert() method. Added `let _ =` to explicitly ignore the return value, consistent with the pattern used elsewhere in the file. Co-authored-by: CBenoit <3809077+CBenoit@users.noreply.github.com> --- testsuite/tests/cli/jetsocat.rs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/testsuite/tests/cli/jetsocat.rs b/testsuite/tests/cli/jetsocat.rs index c046bea6e..03333b836 100644 --- a/testsuite/tests/cli/jetsocat.rs +++ b/testsuite/tests/cli/jetsocat.rs @@ -262,7 +262,7 @@ fn jmux_proxy_write_hello_world() { std::thread::sleep(LISTENER_WAIT_DURATION); // Connect to the JMUX client's local listener. - jetsocat_assert_cmd() + let _ = jetsocat_assert_cmd() .env( "JETSOCAT_ARGS", format!("forward tcp://127.0.0.1:{proxy_listen_port} 'cmd://echo hello world'"), From 5d8b9d1eed3daa5af6c3ec1159aff90233ddd9fc Mon Sep 17 00:00:00 2001 From: "copilot-swe-agent[bot]" <198982749+Copilot@users.noreply.github.com> Date: Wed, 14 Jan 2026 04:10:34 +0000 Subject: [PATCH 3/4] fix(deps): enable serde feature for url crate after 2.5.8 update The url crate update from 2.5.7 to 2.5.8 removed default serde support. Explicitly enable the serde feature in devolutions-agent and http-client-proxy to fix compilation errors. Co-authored-by: CBenoit <3809077+CBenoit@users.noreply.github.com> --- crates/http-client-proxy/Cargo.toml | 2 +- devolutions-agent/Cargo.toml | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/crates/http-client-proxy/Cargo.toml b/crates/http-client-proxy/Cargo.toml index e45a6d65b..cb2509256 100644 --- a/crates/http-client-proxy/Cargo.toml +++ b/crates/http-client-proxy/Cargo.toml @@ -12,7 +12,7 @@ workspace = true proxy_cfg = "0.4" reqwest = { version = "0.12", default-features = false } anyhow = "1.0" -url = "2.5" +url = { version = "2.5", features = ["serde"] } tracing = "0.1" ipnet = "2.10" parking_lot = "0.12" diff --git a/devolutions-agent/Cargo.toml b/devolutions-agent/Cargo.toml index b5bde9ae7..4a9a34b2f 100644 --- a/devolutions-agent/Cargo.toml +++ b/devolutions-agent/Cargo.toml @@ -31,7 +31,7 @@ serde = { version = "1", features = ["derive"] } tap = "1.0" tokio-rustls = { version = "0.26", default-features = false, features = ["logging", "tls12", "ring"] } tracing = "0.1" -url = "2.5" +url = { version = "2.5", features = ["serde"] } [dependencies.ironrdp] version = "0.14" From 01b293d64dc336bc423047e9c05ab8a889045d54 Mon Sep 17 00:00:00 2001 From: "copilot-swe-agent[bot]" <198982749+Copilot@users.noreply.github.com> Date: Wed, 14 Jan 2026 12:47:50 +0000 Subject: [PATCH 4/4] fix(testsuite): properly assert success instead of ignoring return value Changed from `let _ = .assert()` to `.assert().success()` to properly verify command succeeded, following the pattern used throughout the file. Co-authored-by: CBenoit <3809077+CBenoit@users.noreply.github.com> --- testsuite/tests/cli/jetsocat.rs | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/testsuite/tests/cli/jetsocat.rs b/testsuite/tests/cli/jetsocat.rs index 03333b836..57996b9d3 100644 --- a/testsuite/tests/cli/jetsocat.rs +++ b/testsuite/tests/cli/jetsocat.rs @@ -262,13 +262,14 @@ fn jmux_proxy_write_hello_world() { std::thread::sleep(LISTENER_WAIT_DURATION); // Connect to the JMUX client's local listener. - let _ = jetsocat_assert_cmd() + jetsocat_assert_cmd() .env( "JETSOCAT_ARGS", format!("forward tcp://127.0.0.1:{proxy_listen_port} 'cmd://echo hello world'"), ) .timeout(COMMAND_TIMEOUT) - .assert(); + .assert() + .success(); // Kill all processes. let _ = jmux_client.kill();