-
Notifications
You must be signed in to change notification settings - Fork 14
Open
Labels
Description
Currently, we are saving a lot of attributes when the fit(..) function is called (line 120ff):
# Save constructed data.
self.local_kernel = my_kernel
self.epsilon_fitted = my_kernel.epsilon_fitted
self.d = my_kernel.d
self.data = X
self.weights = weights
self.kernel_matrix = kernel_matrix
self.P = P
self.q = q
self.right_norm_vec = right_norm_vec
self.evals = evals
self.evecs = evecs
self.dmap = damp
We should review what exactly needs to be saved here, otherwise we are too heavy on system memory. For example, saving the kernel object instance, the kernel matrix and P (which is the kernel matrix normalised) all separately does create overhead which is not needed.