From 4002c2b327d5191ac80b7e66d52423600e3e23ea Mon Sep 17 00:00:00 2001 From: Alexandre Abadie Date: Fri, 6 Feb 2026 09:55:35 +0100 Subject: [PATCH] dotbot/controller: remove unused dotbot-address parameter --- dotbot/controller.py | 2 -- dotbot/controller_app.py | 9 --------- dotbot/tests/test_controller.py | 3 --- dotbot/tests/test_controller_app.py | 2 -- 4 files changed, 16 deletions(-) diff --git a/dotbot/controller.py b/dotbot/controller.py index cbad560..2058c93 100644 --- a/dotbot/controller.py +++ b/dotbot/controller.py @@ -32,7 +32,6 @@ from dotbot import ( CONTROLLER_ADAPTER_DEFAULT, CONTROLLER_HTTP_PORT_DEFAULT, - DOTBOT_ADDRESS_DEFAULT, GATEWAY_ADDRESS_DEFAULT, MAP_SIZE_DEFAULT, MQTT_HOST_DEFAULT, @@ -136,7 +135,6 @@ class ControllerSettings: mqtt_host: str = MQTT_HOST_DEFAULT mqtt_port: int = MQTT_PORT_DEFAULT mqtt_use_tls: bool = False - dotbot_address: str = DOTBOT_ADDRESS_DEFAULT gw_address: str = GATEWAY_ADDRESS_DEFAULT network_id: str = NETWORK_ID_DEFAULT controller_http_port: int = CONTROLLER_HTTP_PORT_DEFAULT diff --git a/dotbot/controller_app.py b/dotbot/controller_app.py index de7538b..f2b11bd 100644 --- a/dotbot/controller_app.py +++ b/dotbot/controller_app.py @@ -17,7 +17,6 @@ from dotbot import ( CONTROLLER_ADAPTER_DEFAULT, CONTROLLER_HTTP_PORT_DEFAULT, - DOTBOT_ADDRESS_DEFAULT, GATEWAY_ADDRESS_DEFAULT, MAP_SIZE_DEFAULT, MQTT_HOST_DEFAULT, @@ -70,12 +69,6 @@ is_flag=True, help="Use TLS with MQTT (for cloud adapter).", ) -@click.option( - "-d", - "--dotbot-address", - type=str, - help=f"Address in hex of the DotBot to control. Defaults to {DOTBOT_ADDRESS_DEFAULT:>0{16}}", -) @click.option( "-g", "--gw-address", @@ -134,7 +127,6 @@ def main( mqtt_host, mqtt_port, mqtt_use_tls, - dotbot_address, gw_address, network_id, controller_http_port, @@ -157,7 +149,6 @@ def main( "mqtt_host": mqtt_host, "mqtt_port": mqtt_port, "mqtt_use_tls": mqtt_use_tls, - "dotbot_address": dotbot_address, "gw_address": gw_address, "network_id": network_id, "controller_http_port": controller_http_port, diff --git a/dotbot/tests/test_controller.py b/dotbot/tests/test_controller.py index b8bdeb7..b8ccf5d 100644 --- a/dotbot/tests/test_controller.py +++ b/dotbot/tests/test_controller.py @@ -35,7 +35,6 @@ def controller(monkeypatch): port="/dev/null", baudrate=115200, network_id="0", - dotbot_address="456", gw_address="78", ) _controller = Controller(settings) @@ -203,7 +202,6 @@ async def start_simulator(): settings = ControllerSettings( adapter="sailbot-simulator", network_id="0", - dotbot_address="456", gw_address="78", controller_http_port=8000, ) @@ -226,7 +224,6 @@ async def start_simulator(): settings = ControllerSettings( adapter="dotbot-simulator", network_id="0", - dotbot_address="456", gw_address="78", controller_http_port=8001, ) diff --git a/dotbot/tests/test_controller_app.py b/dotbot/tests/test_controller_app.py index 5069d90..8b43c1b 100644 --- a/dotbot/tests/test_controller_app.py +++ b/dotbot/tests/test_controller_app.py @@ -27,8 +27,6 @@ -P, --mqtt-port INTEGER MQTT port used by cloud adapter. Default: 1883. -T, --mqtt-use_tls Use TLS with MQTT (for cloud adapter). - -d, --dotbot-address TEXT Address in hex of the DotBot to control. - Defaults to FFFFFFFFFFFFFFFF -g, --gw-address TEXT Gateway address in hex. Defaults to 0000000000000000 -s, --network-id TEXT Network ID in hex. Defaults to 0000