Skip to content

Variadic support #92

@WyriHaximus

Description

@WyriHaximus

For a project I wanted to have the following DTO, however this package doesn't support the variadic.

<?php

declare(strict_types=1);

namespace WyriHaximus\Apps\WorldOfWarcraft\DataMiner\Images\Worldmap\Full;

use WyriHaximus\Apps\WorldOfWarcraft\DataMiner\Images\Worldmap\Full\Worldmap\Tile;

final readonly class Worldmap
{
    /** @var array<Tile> $tiles */
    public array $tiles;

    public function __construct(
        public string $type,
        public string $version,
        public string $worldmap,
        Tile ...$tiles,
    ) {
        $this->tiles = $tiles;
    }
}

To get it to work I had to create the following, slightly different, DTO (It works fine, but prefer the cleanness of the initial design):

<?php

declare(strict_types=1);

namespace WyriHaximus\Apps\WorldOfWarcraft\DataMiner\Images\Worldmap\Full;

use WyriHaximus\Apps\WorldOfWarcraft\DataMiner\Images\Worldmap\Full\Worldmap\Tile;

final readonly class Worldmap
{
    /** @param array<Tile> $tiles */
    public function __construct(
        public string $type,
        public string $version,
        public string $worldmap,
        public array $tiles,
    ) {
    }
}

Would you be open to a PR adding variadic support?

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions