-
-
Notifications
You must be signed in to change notification settings - Fork 30
Open
Description
For a project I wanted to have the following DTO, however this package doesn't support the variadic.
<?php
declare(strict_types=1);
namespace WyriHaximus\Apps\WorldOfWarcraft\DataMiner\Images\Worldmap\Full;
use WyriHaximus\Apps\WorldOfWarcraft\DataMiner\Images\Worldmap\Full\Worldmap\Tile;
final readonly class Worldmap
{
/** @var array<Tile> $tiles */
public array $tiles;
public function __construct(
public string $type,
public string $version,
public string $worldmap,
Tile ...$tiles,
) {
$this->tiles = $tiles;
}
}To get it to work I had to create the following, slightly different, DTO (It works fine, but prefer the cleanness of the initial design):
<?php
declare(strict_types=1);
namespace WyriHaximus\Apps\WorldOfWarcraft\DataMiner\Images\Worldmap\Full;
use WyriHaximus\Apps\WorldOfWarcraft\DataMiner\Images\Worldmap\Full\Worldmap\Tile;
final readonly class Worldmap
{
/** @param array<Tile> $tiles */
public function __construct(
public string $type,
public string $version,
public string $worldmap,
public array $tiles,
) {
}
}Would you be open to a PR adding variadic support?
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
No labels