Strange Talents (Code Review) #1
Description
README
The README informs me very clearly that this is an agency. I am satisfied with this level of information.
If one was a pedant, one could use words like "absent", "where is it" and "this is only a header", but I have no time for such people and abjure their company.
User stories
- Seems pretty good in general
- I do not know if it can be seen on a small magic vision box, for I am on a large magic vision box.
- Oh wait hang on I can use the firefox preview thing.
- The about us & gallery sections overlap on a phone screen
- Can navigate with keyboard, though sometimes difficult to see what element is being highlighted
- I sort of can navigate it with voiceover
- though if I try to tab down to the content rather than clicking the enter button, it just takes me to the contact section
- It won't read the header text to me
- Screen reader works, semantics seem good
Learning outcomes
- Most of the learning outcomes that I'm qualified to eyeball seem to be hit.
- Colour contrast seems good to me but I've no idea how true that is for different needs
- It's not mobile-first. Yet. But it's got a guy in a chicken costume so like... call it even.
UI bugs
- Overlap between the about us & team sections on narrow screens
Instructions
- A-OK
File structure
- Folder structure is very sensible
- Could do with a gitignore so that the VScode settings don't get uploaded
Flow of control
[ Can you you follow the different paths the code might take?]
Naming
- Did a quick find of const, let & var. All of them are pretty self-explanatory, nice.
Readability
- Yes, and it's really nicely structured actually innit