-
Notifications
You must be signed in to change notification settings - Fork 0
Description
README
[Does the README describe the project using the subheadings: Why?, What?, How? i.e. Why have you created this repo, what does it do, how does it do it?]
Read me is very clear and complete. Just missing the "how to clone it" instructions.
User stories
[Does the project meet the user stories for that week?]
It meet the criteria but they didnt add the user stories themselves. (Not sure if they are neccesary).
It is missing to move the tasks using only the keyboard
Learning outcomes
[Does it demonstrate the learning outcomes for that week?]
The tests are simple and very well organised. No need for async?
UI bugs
[Can you see any obvious bugs or areas to improve?]
Everything on the UI works well, apart from the functionalities of moving and deleting tasks using only the keyboard
Instructions
[Does everything work as expected or were there missing instructions?]
The flow is very clear, no instructions needed. Everything works well by design.
File structure
[When you open the project in your editor, does the file structure make sense?]
Yes, everything makes sense
Flow of control
[ Can you you follow the different paths the code might take?]
Yes, they managed to keep all the functions small and simple. It is very easy to understand it.
Naming
[Do variables and functions have clear and descriptive names?]
Yes
Readability
[Do you understand the code?]
Yes