ToDoodle - code review #16
Description
README
[Does the README describe the project using the subheadings: Why?, What?, How? i.e. Why have you created this repo, what does it do, how does it do it?]
Possibly a bit more to add - maybe more of a focus on the testing aspect?
User stories
[Does the project meet the user stories for that week?]
- adds task to list
- checks things off
- can hide/show completed tasks
- can delete tasks
NICE
Learning outcomes
[Does it demonstrate the learning outcomes for that week?]
- Test for delete
- test for add item
- tests for task being deleted from array
- re scope all global as far as I can see?
- functions that add, remove or modify DOM nodes
- has event listeners
UI bugs
[Can you see any obvious bugs or areas to improve?]
-no, lush
Instructions
[Does everything work as expected or were there missing instructions?]
- no, lush
File structure
[When you open the project in your editor, does the file structure make sense?]
- yes, lush
Flow of control
[ Can you you follow the different paths the code might take?]
- yes mam
Naming
[Do variables and functions have clear and descriptive names?]
- great names. Look to be 0 named by Jason, apart from possibly 'task should exist'
Readability
[Do you understand the code?]
- I enjoy creation of doesXhaveY. Helpful and excellent.