Skip to content

Pickpockets-for-hire - code review #3

@Frannerz

Description

@Frannerz

README

README:
Add Why?, What?, How? i.e. Why have you created this repo, what does it do, how does it do it?

User stories

As a potential client, I want to:

  • Add member info for each team member
  • Responsive on most pages- well done for trying out some media queries! (These might work better at the bottom of your stylesheet)
  • Edit about section to make sure it fits on phone screen
  • Navigation not yet working
  • Great contact section
  • Website hosted on gitpages- add link to repo

Additionally, as a visually impaired user, I want to:

  • Can navigate using keyboard controls
  • Can hear my screen reader describe the links
  • Do all links/images have alt text?
  • (We don't have this either, but...): can screen reader read things other than links
  • Navigation menu is there
  • ‘About us’ section is there- to finish
  • Contact form
  • Ensure user cannot submit a form without filling out all of the mandatory fields (name, company name, email address)- remove action so it doesn't go to a random site
  • Information from the form doesn’t get submitted until the user clicks a button

Learning outcomes

  • Getting there
  • Love your images and styling!

UI bugs

  • Finish stuff

Instructions

N/A

File structure

Some comments on this above (media queries)

Flow of control

[ Can you you follow the different paths the code might take?]

Naming

[Do variables and functions have clear and descriptive names?]

Readability

[Do you understand the code?]

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions