Skip to content

Quake Finder - code review #7

@AlexVOiceover

Description

@AlexVOiceover

README

[Does the README describe the project using the subheadings: Why?, What?, How? i.e. Why have you created this repo, what does it do, how does it do it?]
The readme is clear and gives all the needed info.

User stories

[Does the project meet the user stories for that week?]
Their user stories is very detailed.

Learning outcomes

[Does it demonstrate the learning outcomes for that week?]
They successfully fetches info from the API and shows it on an interactive way (table and map).

UI bugs

[Can you see any obvious bugs or areas to improve?]
Tabindex has a small problem, it's skipping one filed. Apart from that works perfect.
On smartphones the table doesnt fit on the width of the phone.
It should take the default values as proper values, even just for testing.

Instructions

[Does everything work as expected or were there missing instructions?]
The instructions are very detailed and the site does what supposed to.

File structure

[When you open the project in your editor, does the file structure make sense?]
It makes sense and I like the idea of splitting functionality in different js files.

Flow of control

[ Can you you follow the different paths the code might take?]
Looks like, we cannot verify this 100% in 10 minutes.

Naming

[Do variables and functions have clear and descriptive names?]
Variables have descriptive names. Same for functions.

Readability

[Do you understand the code?]
Yes

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions