Skip to content

Document security assumptions about mj-include #64

@FelixSchwarz

Description

@FelixSchwarz

My assumption was always to trust the mjml content:

  • The file might contain might contain untrusted user data, e.g. a name inside a <mj-text> block.
  • However the mjml structure and tags within the content should not be attacker-controlled.

Therefore <mj-include> tags are not a security concern to me - they include whatever the developer wanted to include.

The JS reference implementation seems to take a different approach:

This ticket is a first attempt to convey the security assumptions I made when creating the project. However I'm also open to adding some code which might filter or even block mj-include tags if there is a need (+ willingness to contribute some dev time).

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions