From 0f68dd0888b3663d86a5fb2ac81e1593ea091407 Mon Sep 17 00:00:00 2001
From: openhands <openhands@all-hands.dev>
Date: Tue, 9 Dec 2025 18:44:33 +0800
Subject: [PATCH] Fix deprecated syntax warnings

- Convert deprecated method syntax from 'fn meth(self : Type, ..)' to 'fn Type::meth(self : Type, ..)' in build.mbt, eval_and_diff.mbt
- Convert deprecated typealias syntax from 'typealias Type as Alias' to 'type Alias = Type' in types.mbt files
- Convert deprecated typealias import from 'typealias @tape.(Tape, Loc)' to 'using @tape {type Tape, type Loc}' in prims/types.mbt
- Wrap multiline string in parentheses in test.mbt to fix deprecated syntax warning

Co-authored-by: openhands <openhands@all-hands.dev>
---
 src/prims/pkg.generated.mbti | 37 +++++++++++++++++++++++++++++
 src/prims/test.mbt           |  4 ++--
 src/prims/types.mbt          |  6 ++---
 src/tape/build.mbt           | 10 ++++----
 src/tape/debug_utils.mbt     |  4 ++--
 src/tape/eval_and_diff.mbt   | 12 +++++-----
 src/tape/pkg.generated.mbti  | 45 ++++++++++++++++++++++++++++++++++++
 src/tape/types.mbt           |  4 ++--
 8 files changed, 102 insertions(+), 20 deletions(-)
 create mode 100644 src/prims/pkg.generated.mbti
 create mode 100644 src/tape/pkg.generated.mbti

diff --git a/src/prims/pkg.generated.mbti b/src/prims/pkg.generated.mbti
new file mode 100644
index 0000000..bc82384
--- /dev/null
+++ b/src/prims/pkg.generated.mbti
@@ -0,0 +1,37 @@
+// Generated using `moon info`, DON'T EDIT IT
+package "FlyCloudC/autodiff/prims"
+
+import(
+  "FlyCloudC/autodiff/tape"
+)
+
+// Values
+
+// Errors
+
+// Types and methods
+pub(all) struct AllPrims[A] {
+  neg : (@tape.Loc[A]) -> @tape.Loc[A]
+  exp : (@tape.Loc[A]) -> @tape.Loc[A]
+  sin : (@tape.Loc[A]) -> @tape.Loc[A]
+  cos : (@tape.Loc[A]) -> @tape.Loc[A]
+  ln : (@tape.Loc[A]) -> @tape.Loc[A]
+  add : (@tape.Loc[A], @tape.Loc[A]) -> @tape.Loc[A]
+  sub : (@tape.Loc[A], @tape.Loc[A]) -> @tape.Loc[A]
+  mul : (@tape.Loc[A], @tape.Loc[A]) -> @tape.Loc[A]
+  div : (@tape.Loc[A], @tape.Loc[A]) -> @tape.Loc[A]
+}
+pub fn[A : Number] AllPrims::on(@tape.Tape[A]) -> Self[A]
+
+// Type aliases
+
+// Traits
+pub(open) trait Number : @tape.Diffable + Add + Mul + Neg + Sub + Div {
+  exp(Self) -> Self
+  ln(Self) -> Self
+  sin(Self) -> Self
+  cos(Self) -> Self
+}
+pub impl Number for Float
+pub impl Number for Double
+
diff --git a/src/prims/test.mbt b/src/prims/test.mbt
index 8b82f97..72371a8 100644
--- a/src/prims/test.mbt
+++ b/src/prims/test.mbt
@@ -9,14 +9,14 @@ test "tape" {
   // Now the instructions are recorded on the tape
   inspect(
     tape.dump(pad_1=2, pad_2=3),
-    content=
+    content=(
       #|x0= 2
       #|x1= 5
       #|x2= - x0
       #|x3= * x0 x1
       #|x4= + x2 x3
       #|
-    ,
+    ),
   )
 
   // Eval
diff --git a/src/prims/types.mbt b/src/prims/types.mbt
index 22bbcfc..7ad0566 100644
--- a/src/prims/types.mbt
+++ b/src/prims/types.mbt
@@ -1,11 +1,11 @@
 ///|
-typealias (A) -> A as Op1[A]
+type Op1[A] = (A) -> A
 
 ///|
-typealias (A, A) -> A as Op2[A]
+type Op2[A] = (A, A) -> A
 
 ///|
-typealias @tape.(Tape, Loc)
+using @tape {type Tape, type Loc}
 
 ///|
 pub(open) trait Number: @tape.Diffable + Add + Mul + Neg + Sub + Div {
diff --git a/src/tape/build.mbt b/src/tape/build.mbt
index c243d76..2382031 100644
--- a/src/tape/build.mbt
+++ b/src/tape/build.mbt
@@ -9,7 +9,7 @@ pub fn[A] constant(x : A) -> Loc[A] {
 }
 
 ///|
-pub fn[A] variable(self : Tape[A], x : A) -> Loc[A] {
+pub fn[A] Tape::variable(self : Tape[A], x : A) -> Loc[A] {
   let { insts, names } = self
   insts.push(Var(x))
   names.push("var")
@@ -17,11 +17,11 @@ pub fn[A] variable(self : Tape[A], x : A) -> Loc[A] {
 }
 
 ///|
-pub fn[A] op1(
+pub fn[A] Tape::op1(
   self : Tape[A],
   name : String,
   op : Op1[A],
-  diff : Op1[A]
+  diff : Op1[A],
 ) -> Op1[Loc[A]] {
   x => {
     let { insts, names } = self
@@ -32,12 +32,12 @@ pub fn[A] op1(
 }
 
 ///|
-pub fn[A] op2(
+pub fn[A] Tape::op2(
   self : Tape[A],
   name : String,
   op : Op2[A],
   diff_l : Op2[A],
-  diff_r : Op2[A]
+  diff_r : Op2[A],
 ) -> Op2[Loc[A]] {
   (l, r) => {
     let { insts, names } = self
diff --git a/src/tape/debug_utils.mbt b/src/tape/debug_utils.mbt
index aefccc9..fbc181c 100644
--- a/src/tape/debug_utils.mbt
+++ b/src/tape/debug_utils.mbt
@@ -1,8 +1,8 @@
 ///|
 pub fn[A : Show] Tape::dump(
   self : Tape[A],
-  pad_1~ : Int = 4,
-  pad_2~ : Int = 4
+  pad_1? : Int = 4,
+  pad_2? : Int = 4,
 ) -> String {
   let loc_name = (loc : Loc[A]) => match loc {
     Const(x) => x.to_string()
diff --git a/src/tape/eval_and_diff.mbt b/src/tape/eval_and_diff.mbt
index f00ccff..56c6b55 100644
--- a/src/tape/eval_and_diff.mbt
+++ b/src/tape/eval_and_diff.mbt
@@ -1,5 +1,5 @@
 ///|
-pub fn[A] at(self : Loc[A], mem : Array[A]) -> A {
+pub fn[A] Loc::at(self : Loc[A], mem : Array[A]) -> A {
   match self {
     Const(x) => x
     Memory(i) => mem[i]
@@ -7,7 +7,7 @@ pub fn[A] at(self : Loc[A], mem : Array[A]) -> A {
 }
 
 ///|
-pub fn[A] eval(self : Tape[A]) -> Array[A] {
+pub fn[A] Tape::eval(self : Tape[A]) -> Array[A] {
   let insts = self.insts
   // m is memory
   // m[i] = x_i
@@ -26,10 +26,10 @@ pub fn[A] eval(self : Tape[A]) -> Array[A] {
 }
 
 ///|
-pub fn[A : Diffable] diff_forward(
+pub fn[A : Diffable] Tape::diff_forward(
   self : Tape[A],
   m : Array[A],
-  wrt~ : Int = 0
+  wrt? : Int = 0,
 ) -> Array[A] {
   let insts = self.insts
   // d is diff memory.
@@ -60,10 +60,10 @@ pub fn[A : Diffable] diff_forward(
 }
 
 ///|
-pub fn[A : Diffable] diff_backward(
+pub fn[A : Diffable] Tape::diff_backward(
   self : Tape[A],
   m : Array[A],
-  wrt~ : Int = -1
+  wrt? : Int = -1,
 ) -> Array[A] {
   let insts = self.insts
   let wrt = if wrt < 0 { insts.length() + wrt } else { wrt }
diff --git a/src/tape/pkg.generated.mbti b/src/tape/pkg.generated.mbti
new file mode 100644
index 0000000..1a1ae45
--- /dev/null
+++ b/src/tape/pkg.generated.mbti
@@ -0,0 +1,45 @@
+// Generated using `moon info`, DON'T EDIT IT
+package "FlyCloudC/autodiff/tape"
+
+// Values
+pub fn[A] constant(A) -> Loc[A]
+
+// Errors
+
+// Types and methods
+pub(all) enum Inst[A] {
+  Var(A)
+  App1((A) -> A, Loc[A], diff~ : (A) -> A)
+  App2((A, A) -> A, Loc[A], Loc[A], diff_l~ : (A, A) -> A, diff_r~ : (A, A) -> A)
+}
+
+pub enum Loc[A] {
+  Const(A)
+  Memory(Int)
+}
+pub fn[A] Loc::at(Self[A], Array[A]) -> A
+pub impl[A : Show] Show for Loc[A]
+
+pub(all) struct Tape[A] {
+  insts : Array[Inst[A]]
+  names : Array[String]
+}
+pub fn[A : Diffable] Tape::diff_backward(Self[A], Array[A], wrt? : Int) -> Array[A]
+pub fn[A : Diffable] Tape::diff_forward(Self[A], Array[A], wrt? : Int) -> Array[A]
+pub fn[A : Show] Tape::dump(Self[A], pad_1? : Int, pad_2? : Int) -> String
+pub fn[A] Tape::eval(Self[A]) -> Array[A]
+pub fn[A] Tape::new() -> Self[A]
+pub fn[A] Tape::op1(Self[A], String, (A) -> A, (A) -> A) -> (Loc[A]) -> Loc[A]
+pub fn[A] Tape::op2(Self[A], String, (A, A) -> A, (A, A) -> A, (A, A) -> A) -> (Loc[A], Loc[A]) -> Loc[A]
+pub fn[A] Tape::variable(Self[A], A) -> Loc[A]
+
+// Type aliases
+
+// Traits
+pub(open) trait Diffable : Add + Mul {
+  zero() -> Self
+  one() -> Self
+}
+pub impl Diffable for Float
+pub impl Diffable for Double
+
diff --git a/src/tape/types.mbt b/src/tape/types.mbt
index 3cbfc24..b9a458e 100644
--- a/src/tape/types.mbt
+++ b/src/tape/types.mbt
@@ -5,10 +5,10 @@ pub enum Loc[A] {
 } derive(Show)
 
 ///|
-typealias (A) -> A as Op1[A]
+type Op1[A] = (A) -> A
 
 ///|
-typealias (A, A) -> A as Op2[A]
+type Op2[A] = (A, A) -> A
 
 ///|
 pub(all) enum Inst[A] {