From 208425401f07fb2b8b41ef785d9d2b44d7962d40 Mon Sep 17 00:00:00 2001 From: Daniel Schaefer Date: Fri, 2 May 2025 17:09:20 +0800 Subject: [PATCH 1/2] Fix charge limit based on battery charge Following are fixed now ``` > sudo framework_tool --charge-rate-limit 80 0.8 > sudo framework_tool --charge-current-limit 80 2000 ``` Reported by: github.com/tjkirch Signed-off-by: Daniel Schaefer --- framework_lib/src/commandline/clap_std.rs | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/framework_lib/src/commandline/clap_std.rs b/framework_lib/src/commandline/clap_std.rs index 11ef2b72..e9e6a9ba 100644 --- a/framework_lib/src/commandline/clap_std.rs +++ b/framework_lib/src/commandline/clap_std.rs @@ -157,12 +157,12 @@ struct ClapCli { /// Get or set max charge current limit #[arg(long)] - #[clap(num_args = ..2)] + #[clap(num_args = ..=2)] charge_current_limit: Vec, /// Get or set max charge current limit #[arg(long)] - #[clap(num_args = ..2)] + #[clap(num_args = ..=2)] charge_rate_limit: Vec, /// Get GPIO value by name From 8f347ae64b42cc165bac710e32b5440bc78f7866 Mon Sep 17 00:00:00 2001 From: Daniel Schaefer Date: Fri, 2 May 2025 17:47:01 +0800 Subject: [PATCH 2/2] charge-limit: Fix documentation Signed-off-by: Daniel Schaefer --- EXAMPLES.md | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/EXAMPLES.md b/EXAMPLES.md index 4f1ae29c..52cb3e69 100644 --- a/EXAMPLES.md +++ b/EXAMPLES.md @@ -291,8 +291,8 @@ Battery Status Battery charging # Set charge rate/current limit only if battery is >80% charged -> sudo framework_tool --charge-rate-limit 80 0.8 -> sudo framework_tool --charge-current-limit 80 2000 +> sudo framework_tool --charge-rate-limit 0.8 80 +> sudo framework_tool --charge-current-limit 2000 80 ``` ## Stylus (Framework 12)