-
Notifications
You must be signed in to change notification settings - Fork 80
Description
Hey thanks for making this, so far it's been great!
One thing I've noticed is that it uses window.open() to open the login page, etc. Unfortunately a lot of people have popup blockers installed, in which case this may not work (and to them it just seems like the extension is broken / they can't use it).
I've made some updates on my end to ExtPay.js, which simply opens the page in the current tab instead:
window.open('xxx') vs window.location.href = 'xxx'
That works fine and it's a really simple update - though it would be great if that were an available option in the main build.
That said, when you open a lot of these pages in a full tab, the layouts are a bit messed up. They're almost correct, but the title isn't centered, etc. Which makes everything look a bit less professional, almost dodgy even haha.
I would fix those layouts, but they're part of the extension pay website - so I've got no control over them. I don't think there's a lot of work that would be needed to fix them up, as mentioned they're almost correct already.
So in summary, it'd be awesome if we could:
- Have an option to open pages in
- A new tab
- The same tab
- A popup
- Fix the layouts of the login, pay, etc pages on the extension pay website - so they look good at all resolutions when opened in a full tab.
Thanks again! I'm working on an extension which may put a lot of users through soon. Hopefully it makes you some passive income :)