Oauth authorize_url example does not work anymore

[Sokre95]

Example in https://github.com/HubSpot/sample-apps-oauth/blob/main/ruby/app/lib/services/authorization/get_authorization_uri.rb
does not work anymore after change in (change to positional method arguments instead of keyword arguments for some reson)
HubSpot/hubspot-api-ruby@7a6126a

[gregblass]

I just ran into this as welll.

There's a mismatch between how the method is being called and how it's defined. The method is defined with positional parameters:

def authorize_url(client_id, redirect_uri, scopes = nil, optional_scopes = nil, state = nil)

But it's being called with keyword arguments (named parameters):

authorize_url(
  client_id: ENV['HUBSPOT_CLIENT_ID'],
  redirect_uri: redirect_uri,
  scope: %[crm.objects.contacts.read crm.objects.contacts.write]
)

To fix this, the method call should be changed to use positional arguments:

authorize_url(
  ENV['HUBSPOT_CLIENT_ID'],
  redirect_uri,
  %w[crm.objects.contacts.read crm.objects.contacts.write]
)

In addition, the array syntax in this class/method (GetAuthorizationUri) is incorrect. Instead of %[...], it should be %w[...] for a word array in Ruby.

The HubSpot developer support has come a long way over the years. We finally are converting from the old Ruby gem to use the official hubspot ruby gem. I convinced my team this was a good idea, so its a bit of a let down to see example code that is not maintained.

I can probably figure this out on my own - but it would be great if HubSpot team could address this at some point. As it stands, this example app does not work.