[Suggestion] UI Changes

[newhinton]

Since it seems you are reviving this app, (Thank you for that!) do you want suggestions for improvements? If you want to hear them, i could make some mockups.

[IvanVolosyuk]

I'm trying to make minimal changes to keep it functional on newer devices without breaking functionality on older ones. I cannot say I'm successful at that. There are reports of regression on older devices as well as broken functionality in new ones. That's the reason I am not publishing the app to play store. I can merge pull requests though if the changes don't break more than what's already broken.

…

On Sat, Jan 13, 2024, 08:32 Felix Nüsse ***@***.***> wrote: Since it seems you are reviving this app, (Thank you for that!) do you want suggestions for improvements? If you want to hear them, i could make some mockups. — Reply to this email directly, view it on GitHub <#94>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ABXQ6HNNHCMJ355Y4KGOTCLYOGTXBAVCNFSM6AAAAABBYXOXRGVHI2DSMVQWIX3LMV43ASLTON2WKOZSGA3TSNZVGQ2DQOI> . You are receiving this because you are subscribed to this thread.Message ID: ***@***.***>

[newhinton]

Oh i was talking specifically about UI-changes, those should not break anything.

Though i probably will not find time to implement anything major.

I know this deviates from the toppic, but isnt dropping support for android 5&6 fine? Those are nearly ten years old, and with android 7 you have to use SAF anyway.

[IvanVolosyuk]

I guess it's fine.

…

On Sat, Jan 13, 2024 at 7:14 PM Felix Nüsse ***@***.***> wrote: Oh i was talking specifically about UI-changes, those should not break anything. Though i probably will not find time to implement anything major. I know this deviates from the toppic, but isnt dropping support for android 5&6 fine? Those are nearly ten years old, and with android 7 you have to use SAF anyway. — Reply to this email directly, view it on GitHub <#94 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ABXQ6HLJMVHQ4V4KLKM5LGTYOI66HAVCNFSM6AAAAABBYXOXRGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQOJQGM3TKNJSGQ> . You are receiving this because you commented.Message ID: ***@***.***>

[newhinton]

What i imagine is this:

However, experimenting with the codebase, i found that this is not a trivial task. From what i see, this requires re-implementing the full user interface code, replacing all current activities with one new one. In addition to that, it also requires a more strict decoupling between the UI, the renderer and the filesystem structure.

While that is a huge task, that might ease maintenance in the future. It also allows us to experiment with different visualizations, because we just need to create a new visualization, instead of working around the current implementation.

What do you think, is this something i should move forward with? If i do, i will probably create a huge PR that replaces the old UI with the new one.

[IvanVolosyuk]

Well, the current memory layout was designed in 2008 for the amount of ram available at that time (192MB). We can definitely revisit that now. Do you want to replace the current UI or add another representation? I'm fine for decoupling the storage and presentation, but I would definitely prefer to keep the original UI with all the features including proper animations and keyboard navigation.

…

On Sun, Jan 14, 2024 at 5:56 AM Felix Nüsse ***@***.***> wrote: What i imagine is this: image.png (view on web) <https://github.com/IvanVolosyuk/diskusage/assets/25279821/612db8dd-940a-45e5-999b-2a32a5ab1f98> However, experimenting with the codebase, i found that this is not a trivial task. From what i see, this requires re-implementing the full user interface code, replacing all current activities with one new one. In addition to that, it also requires a more strict decoupling between the UI, the renderer and the filesystem structure. While that is a huge task, that might ease maintenance in the future. It also allows us to experiment with different visualizations, because we just need to create a new visualization, instead of working around the current implementation. What do you think, is this something i should move forward with? If i do, i will probably create a huge PR that replaces the old UI with the new one. — Reply to this email directly, view it on GitHub <#94 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ABXQ6HJ2YSEYLBOT56BMSADYOLKETAVCNFSM6AAAAABBYXOXRGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQOJQG4YDSMJRGU> . You are receiving this because you commented.Message ID: ***@***.***>

[newhinton]

Do you want to replace the current UI or add another representation?

With UI i meant everything that is not a graph ;) I have experimented a bit and could make a different graph work (as a prototype), but my goal is to replicate the current version in terms of feature and looks, but in decoupled.

So for now i am going to keep the original renderer, but rework it so it works standalone, so that it becomes possible to add more, replace or change the graph without breaking the rest of the application.

[IvanVolosyuk]

Sounds good to me.

…

On Sun, Jan 14, 2024 at 8:23 PM Felix Nüsse ***@***.***> wrote: Do you want to replace the current UI or add another representation? With UI i meant everything that is not a graph ;) I have experimented a bit and could make a different graph work (as a prototype), but my goal is to replicate the current version in terms of feature and looks, but in decoupled. So for now i am going to keep the original renderer, but rework it so it works standalone, so that it becomes possible to add more, replace or change the graph without breaking the rest of the application. — Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you commented.Message ID: ***@***.***>