diff --git a/install-gcam.py b/install-gcam.py index 36ebc03..32de937 100755 --- a/install-gcam.py +++ b/install-gcam.py @@ -80,7 +80,26 @@ def untar(filename, directory='.', printOnly=False): return with tarfile.open(filename, mode='r:gz') as tar: - tar.extractall(path=directory) + def is_within_directory(directory, target): + + abs_directory = os.path.abspath(directory) + abs_target = os.path.abspath(target) + + prefix = os.path.commonprefix([abs_directory, abs_target]) + + return prefix == abs_directory + + def safe_extract(tar, path=".", members=None, *, numeric_owner=False): + + for member in tar.getmembers(): + member_path = os.path.join(path, member.name) + if not is_within_directory(path, member_path): + raise Exception("Attempted Path Traversal in Tar File") + + tar.extractall(path, members, numeric_owner=numeric_owner) + + + safe_extract(tar, path=directory) # # Comment taken from exe/run-gcam.command: