On supporting latest libxposed version.

[gynwcaafzb]

Hi.
As of 7b67273 the @XposedHooker annotation was removed making LSposed incompatible.

You said:

@privacyguy123 I simply checkout the commit before this one in the build.

Do you intentionally not support using the latest libxposed version?

[JingMatrix]

No, I have plan to keep update with the libxposed Xposed API and they are indeed fully implemented (except two not important some APIs, to be done during the rewriting into Vector).

The annotation change is an internal technique detail, which doesn't affect the API availability.
Don't confuse them, it is more like different ways of implementing the same API.

[gynwcaafzb]

doesn't affect the API availability

Does not seem to be true.

I'm using LSposed 1.10.2 on LineageOS 15 (no gapps; root via magisk patch).

I'm relying on the new before/after method convention introduced in the latest libxposed so my hooker crashes with the following error:

----part 1 start----
[LogWatchDog started]
[LogWatchDog running] log.tag: ; logd.[default, crash, main, system].size: [131072,131072,131072,131072]
[ [REDACTED]     1000:  1528:  2357 I/LSPosed-Bridge  ] binder received
[ [REDACTED]     1000:  2939:  2939 I/LSPosedContext  ] [REDACTED]: ModuleMain at com.android.settings
[ [REDACTED]     1000:  2939:  2939 I/LSPosedContext  ] [REDACTED]: testing...
[ [REDACTED]     1000:  2939:  2939 I/LSPosedContext  ] [REDACTED]: onPackageLoaded: com.android.settings
[ [REDACTED]     1000:  2939:  2939 I/LSPosedContext  ] [REDACTED]: param classloader is dalvik.system.PathClassLoader[DexPathList[[zip file "/system_ext/priv-app/Settings/Settings.apk"],nativeLibraryDirectories=[/system_ext/priv-app/Settings/lib/arm64, /system_ext/priv-app/Settings/Settings.apk!/lib/arm64-v8a, /system/lib64, /system_ext/lib64, /system/lib64, /system_ext/lib64]]]
[ [REDACTED]     1000:  2939:  2939 I/LSPosedContext  ] [REDACTED]: module apk path: [REDACTED]
[ [REDACTED]     1000:  2939:  2939 I/LSPosedContext  ] [REDACTED]: ----------
[ [REDACTED]     1000:  2939:  2939 E/LSPosedContext  ] Error when calling onPackageLoaded of [REDACTED]
java.lang.IllegalArgumentException: Hooker should be annotated with @XposedHooker
	at g0.a(Unknown Source:335)
	at n0.hook(SourceFile:1)
	at io.github.libxposed.api.XposedInterfaceWrapper.hook(SourceFile:1)
	at [REDACTED].MyXposedModule.onPackageLoaded(MyXposedModule.java:33)
	at n0.c(Unknown Source:18)
	at D0.b(Unknown Source:293)
	at java.lang.reflect.Method.invoke(Native Method)
	at org.lsposed.lspd.impl.LSPosedBridge$NativeHooker.callback(Unknown Source:242)
	at LSPHooker_.createOrUpdateClassLoaderLocked(Unknown Source:11)
	at android.app.LoadedApk.getClassLoader(LoadedApk.java:1134)
	at android.app.LoadedApk.getResources(LoadedApk.java:1382)
	at android.app.ContextImpl.createAppContext(ContextImpl.java:3489)
	at android.app.ContextImpl.createAppContext(ContextImpl.java:3480)
	at android.app.ActivityThread.handleBindApplication(ActivityThread.java:7575)
	at android.app.ActivityThread.-$$Nest$mhandleBindApplication(Unknown Source:0)
	at android.app.ActivityThread$H.handleMessage(ActivityThread.java:2500)
	at android.os.Handler.dispatchMessage(Handler.java:109)
	at android.os.Looper.loopOnce(Looper.java:232)
	at android.os.Looper.loop(Looper.java:317)
	at android.app.ActivityThread.main(ActivityThread.java:8934)
	at java.lang.reflect.Method.invoke(Native Method)
	at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:591)
	at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:911)

[JingMatrix]

You are right, I understood it wrongly without doing any experiments.
It is not only internal since there is an enforced runtime check.

[JingMatrix]

@gynwcaafzb Please test the latest CI build to see if the libxposed API support is properly done.

[yashikada]

Is it worth using libxposed, which has been discontinued for a while now?
I'm using the mywalkb/LSPosed_mod APIs and I'm happy with them, they work perfectly for my module.

[JingMatrix]

Not, not necessarily.

libxposed is a super set of the classic Xposed API, it is worthy to understand and practice it.
You are, however, not obliged to follow it.

[yashikada]

well, thanks for the replies, I will have to migrate to libxposed so I can use your version of LSPosed.