-
Notifications
You must be signed in to change notification settings - Fork 83
Description
The LightVisibility and CubeVisibility assets have a wrong name entry in their metadata.json.
- The
nameofLightVisibilityis "Light Visiblity test for KHR_node_visibility" - The
nameofCubeVisibilityis "Cube Visiblity test for KHR_node_visibility"
The name must be the ~"actual/general/global name" of that asset, verbatim, i.e. it must only be "LightVisibility" and "CubeVisibility", respectively.
@aaronfranke This slipped though during the review of #235 because
- it is not documented(!) and
- the effect (i.e. the resulting issue) is not obvious
I also didn't have on the radar that deviating from this rule would break downstream pipelines - maybe because there haven't been downstream pipelines until recently. But I just noticed that https://github.khronos.org/glTF-Assets/ chokes on these assets:
This moves the task to straighten out and update the submission guidelines (c.f. #39 ) a bit higher on my TODO list. (I already started doing things like #254 , but will have to dive deeper into that PHP script first...)