Skip to content

Wrong names for LightVisibility and CubeVisbility #261

@javagl

Description

@javagl

The LightVisibility and CubeVisibility assets have a wrong name entry in their metadata.json.

The name must be the ~"actual/general/global name" of that asset, verbatim, i.e. it must only be "LightVisibility" and "CubeVisibility", respectively.


@aaronfranke This slipped though during the review of #235 because

  1. it is not documented(!) and
  2. the effect (i.e. the resulting issue) is not obvious

I also didn't have on the radar that deviating from this rule would break downstream pipelines - maybe because there haven't been downstream pipelines until recently. But I just noticed that https://github.khronos.org/glTF-Assets/ chokes on these assets:

Image

This moves the task to straighten out and update the submission guidelines (c.f. #39 ) a bit higher on my TODO list. (I already started doing things like #254 , but will have to dive deeper into that PHP script first...)

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions