validators might fail for name and alias unique false

[mpgh]

The validators get_or_create_event method does not catch all possible combinations of booleans and risks to return the non-iterable None.

Possible fix, add the following at the end of the method

 if not name_unique and not alias_unique:
        tn = TargetName.objects.get(name=name)
        t = Target.objects.get(pk=tn.target_id)
        created = False
        print('Matched Target ' + name + ' by alias to ' + t.name + ', pk=' + str(t.pk))
        return t, 'non_existing_target_existing_alias'

[KKruszynska]

Hi Markus, could you give me more details? When is this issue occurring, and to which section of the code do you refer when you mention get_or_create_event method?

[mpgh]

It occurred during running the harvester in the OPM when ingesting OGLE 2025 data. This part of the code is identical. One of the events was in a state (perhaps due to an unfinished ingest) where a combination of booleans were not caught in the if statements resulting in a None of the function in https://github.com/LCOGT/mop/blob/master/microlensing_targets/match_managers/validators.py