Refactor identity name generation to use array join for improved readability

tacxou · tacxou · commit 39c0c94b879a · 2025-01-08T15:22:40.000+01:00
diff --git a/src/management/identities/identities-crud.controller.ts b/src/management/identities/identities-crud.controller.ts
@@ -78,10 +78,16 @@ export class IdentitiesCrudController extends AbstractController {
       body.inetOrgPerson.employeeType = 'LOCAL';
     }
     if (!body.inetOrgPerson.cn) {
-      body.inetOrgPerson.cn = `${(body.inetOrgPerson.sn || '').toUpperCase()} ${body.inetOrgPerson.givenName}`;
+      body.inetOrgPerson.cn = [
+        body.inetOrgPerson.sn?.toUpperCase(),
+        body.inetOrgPerson.givenName,
+      ].join(' ').trim();
     }
     if (!body.inetOrgPerson.displayName) {
-      body.inetOrgPerson.displayName = body.inetOrgPerson.givenName + ' ' + (body.inetOrgPerson.sn || '').toUpperCase();
+      body.inetOrgPerson.displayName = [
+        body.inetOrgPerson.givenName,
+        body.inetOrgPerson.sn?.toUpperCase(),
+      ].join(' ').trim();
     }
     const data = await this._service.create<Identities>(body);
     // If the state is TO_COMPLETE, the identity is created but additional fields are missing or invalid

Original file line number	Diff line number	Diff line change
`@@ -78,10 +78,16 @@ export class IdentitiesCrudController extends AbstractController {`
`78`	`78`	`body.inetOrgPerson.employeeType = 'LOCAL';`
`79`	`79`	`}`
`80`	`80`	`if (!body.inetOrgPerson.cn) {`
`81`		- body.inetOrgPerson.cn = `${(body.inetOrgPerson.sn \|\| '').toUpperCase()} ${body.inetOrgPerson.givenName}`;
	`81`	`+ body.inetOrgPerson.cn = [`
	`82`	`+ body.inetOrgPerson.sn?.toUpperCase(),`
	`83`	`+ body.inetOrgPerson.givenName,`
	`84`	`+ ].join(' ').trim();`
`82`	`85`	`}`
`83`	`86`	`if (!body.inetOrgPerson.displayName) {`
`84`		`- body.inetOrgPerson.displayName = body.inetOrgPerson.givenName + ' ' + (body.inetOrgPerson.sn \|\| '').toUpperCase();`
	`87`	`+ body.inetOrgPerson.displayName = [`
	`88`	`+ body.inetOrgPerson.givenName,`
	`89`	`+ body.inetOrgPerson.sn?.toUpperCase(),`
	`90`	`+ ].join(' ').trim();`
`85`	`91`	`}`
`86`	`92`	`const data = await this._service.create<Identities>(body);`
`87`	`93`	`// If the state is TO_COMPLETE, the identity is created but additional fields are missing or invalid`