Make employeeType required in inetOrgPerson schema and simplify update handling in IdentitiesCrudService

Author: tacxou

src/management/identities/_schemas/_parts/inetOrgPerson.part.ts

@@ -60,7 +60,7 @@ export class inetOrgPerson extends Document {
   })
   public employeeNumber: string[];
 
-  @Prop({ type: String })
+  @Prop({ type: String, required: true })
   public employeeType: string;
 
   @Prop({ type: Array, of: String, required: true, default: [] })

src/management/identities/identities-crud.service.ts

@@ -55,8 +55,7 @@ export class IdentitiesCrudService extends AbstractIdentitiesService {
 
     // if (update.state === IdentityState.TO_COMPLETE) {
     update = {
-      ...omit(update, ['inetOrgPerson']),
-      inetOrgPerson: omit(update.inetOrgPerson, ['employeeNumber', 'employeeType']),
+      ...update,
       state: IdentityState.TO_VALIDATE,
     };