From cecdbae714784ca4467c6b2ccdc6789bb9a0bbbb Mon Sep 17 00:00:00 2001
From: "John L. Villalovos" <john@sodarock.com>
Date: Sat, 14 Feb 2026 22:01:15 -0800
Subject: [PATCH] test(phpstan): Enable phpstan level 3 typing in `Controls/`

Enable PHPStan level 3 checking for the `Controls/` directory.

Fix issues found.
---
 Controls/Dashboard/PastReservations.php     | 6 +++---
 Controls/Dashboard/UpcomingReservations.php | 2 +-
 phpstan_next.neon                           | 1 -
 3 files changed, 4 insertions(+), 5 deletions(-)

diff --git a/Controls/Dashboard/PastReservations.php b/Controls/Dashboard/PastReservations.php
index 01d3b06da..6ac417f21 100644
--- a/Controls/Dashboard/PastReservations.php
+++ b/Controls/Dashboard/PastReservations.php
@@ -8,7 +8,7 @@
 class PastReservations extends DashboardItem implements IPastReservationsControl
 {
     /**
-     * @var PastReservationsPresenter
+     * @var PastReservationsPresenter|MissingCheckInOutReservationsPresenter
      */
     protected $presenter;
 
@@ -106,8 +106,8 @@ public function PageLoad()
 class MissingCheckInOutReservations extends PastReservations implements IRemainingPastReservationsControl
 {
     /**
-         * @var MissingCheckInOutReservationsPresenter
-         */
+     * @var MissingCheckInOutReservationsPresenter
+     */
     protected $presenter;
 
     public function __construct(SmartyPage $smarty)
diff --git a/Controls/Dashboard/UpcomingReservations.php b/Controls/Dashboard/UpcomingReservations.php
index 7a167c715..57fea13e6 100644
--- a/Controls/Dashboard/UpcomingReservations.php
+++ b/Controls/Dashboard/UpcomingReservations.php
@@ -9,7 +9,7 @@
 class UpcomingReservations extends DashboardItem implements IUpcomingReservationsControl
 {
     /**
-     * @var UpcomingReservationsPresenter
+     * @var UpcomingReservationsPresenter|GroupUpcomingReservationsPresenter|PendingApprovalReservationsPresenter
      */
     protected $presenter;
 
diff --git a/phpstan_next.neon b/phpstan_next.neon
index 33c7a11c7..bb0be3d6f 100644
--- a/phpstan_next.neon
+++ b/phpstan_next.neon
@@ -34,7 +34,6 @@ parameters:
             - vendor/
             # Staged "next level" rollout: remove these one-by-one as each
             # area is fixed for the current target level.
-            - Controls/
             - Domain/
             - Pages/
             - Presenters/