Support request for pdfmake 0.2.X

[Leccho]

Add support for pdfmake 0.2.X

[anodynos]

@Lugriz any chance for 0.2.x support? Or even the new 0.3.x still in beta? Is it too much work?
I can see some work is already done here - can it be merged/released? https://github.com/Lugriz/pdfmake-wrapper/compare/fix-pdfmake-compatibility

[Leccho]

@anodynos I think this project is not supported anymore. I've been using pdfmake directly lately. You don't have to change much to make it work.

[anodynos]

Thanks, it was first attempt with it, I finally managed to make v0.2.7 play nice with typescript, so no probs 😉

[Leccho]

@anodynos I ended up using pdfmake backend with typescript:
Install dependencies

npm i pdfmake
npm i -D @types/pdfmake

Your service or equivalent:

import { createPdf, TCreatedPdf } from 'pdfmake/build/pdfmake';
import * as pdfFonts from 'pdfmake/build/vfs_fonts';
import { Content, TDocumentDefinitions } from 'pdfmake/interfaces';

export class PdfService {
  public createPdf(): Promise<Buffer> {
    const documentDefinitions: TDocumentDefinitions = { ... };
    const pdf: TCreatedPdf = createPdf(documentDefinitions, undefined, undefined, pdfFonts.pdfMake.vfs);
    const buffer: Buffer | void = await new Promise((resolve: (buffer: Buffer) => void): void => {
      pdf.getBuffer((b: Buffer): void => resolve(b));
    }).catch((): void => {
      // currently not working since there's no way to catch errors and create a reject of the promise
      // this is a problem with pdfmake
      throw new InternalServerErrorException('Could not create pdf');
    });
    if (!buffer) {
      throw new InternalServerErrorException('Could not create pdf');
    }
    return Buffer.from(buffer);
  }
}

[anodynos]

Thanks @Leccho ;-)

[veslav3]

Nice to hear we can use pdfmake directly. We get the following warning currently: Warning:(55, 17) Dependency npm:pdfmake:0.1.72 is vulnerable, safe version 0.2.7 CVE-2022-46161 9.8 Improper Control of Generation of Code ('Code Injection') vulnerability with high severity found Results powered by Checkmarx(c)

[ZaLiTHkA]

@Lugriz, I understand that you don't feel the need to keep this project going, but would you be so kind as to push one final small commit and publish one last release for us?

pdfmake 0.2 does not have any breaking changes from 0.1, but it does have bug and security fixes.. I can't say I've tried every single feature and checked every single type definition, but from some basic testing now, it seems the current pdfmake-wrapper build does still work with pdfmake@0.2.18, as long as pdfmake-wrapper's package.json allows it to be installed.

if you could update the devDependencies on lines 44 and 50 as follows:

• "@types/pdfmake": "^0.1.21 || ^0.2.0",
• "pdfmake": "^0.1.72 || ^0.2.0",

..then at least those of us who do not have the time to migrate from 0.1 to 0.3 can use 0.2 in the meantime. perhaps even as a "beta" version, just so we have to explicitly specify a tag to install?

I did consider sharing my fork with these changes, but unless I add yet another package to the NPM registry that will not be maintained, the only other option is to commit the dist folder to Git and then install from a GitHub project subfolder using something like Vercel's "GitPkg" service (as I'm currently doing).