Low charge modifier towards damage

[SaintWish]

If you attack too quickly you'll end up doing way less damage then what you should be doing.

it's doing the damage scaling of a partial charge but multiplying by a value less than 0.1

[SaintWish]

long randomMulti = RANDOM_LONG(0, CurrentAttack->flDamageRange);
float flDamage = CurrentAttack->flDamage + randomMulti;
flDamage *= flDmgFraction;
if (bUnderleveled)
	flDamage *= 0.5; //this might be working

//Print( "In damage: %f\nLast charged: %f\n", flDamage, m_LastChargedAmt );
if (m_LastChargedAmt > 0 && m_LastChargedAmt < 1)
{
	Print("Out damage: %f\n", flDamage *= m_LastChargedAmt);
	flDamage *= m_LastChargedAmt;
}

Seems to happen at this function

MasterSwordRebirth/src/game/shared/weapons/giattack.cpp

Line 736 in 57c26f8

void CGenericItem::StrikeLand()

Randomly float flDamage = CurrentAttack->flDamage + randomMulti; will output the completely incorrect math resulting lower than expected. Ex. CurrentAttack->flDamage = 225.0 + randomMulti = -17 the return should 208 but instead ends up being around 11.
All the while CurrentAttack->flDamage always remains the same valve so that isn't changing.

[Rederick5]

	if (m_LastChargedAmt > 0 && m_LastChargedAmt < 1)
	{
		Print("Out damage: %f\n", flDamage *= m_LastChargedAmt);
		flDamage *= m_LastChargedAmt;
	}

Looks like flDamage is being *= multiple times. Statement is an assignment for the print operation on line 794. Should this instead be:

 if (m_LastChargedAmt > 0 && m_LastChargedAmt < 1)
	{
                flDamage *= m_LastChargedAmt;
		Print("Out damage: %f\n", flDamage);
		
	}

[Rederick5]

I can't push changes to the repo yet, but I dug a bit further and noticed something else regarding how the crit and threshold ternary operators are making decisions, and how the charge multiple was reducing damage.

Charge snippet alteration to prevent double calculation and reduction:
(if the intent is to give bonus damage to a normal attack while it is charging but hasn't reached a single charge)

	if (m_LastChargedAmt > 0 && m_LastChargedAmt < 1)
	{
		flDamage *= (m_LastChargedAmt+1);
		Print( "In damage: %f\nLast charged: %f\n", flDamage, m_LastChargedAmt );	
	}

Crit Chance/ Crit Damage Multi Snippet:

//Crits - Only player get default crit chance and multiplier
float flBaseCritChance  = 5.0f
float flBaseCritFailure = 100.0f - flBaseCritChance
float flBaseCritMulti   = 1.5f

if (m_pOwner->IsPlayer()) { 
	//if has a greater crit chance than base, choose that, else default to base chance.
	Damage.flCritThreshold = CurrentAttack->flCritThreshold < flBaseCritFailure ? CurrentAttack->flCritThreshold : flBaseCritFailure;

	//if has  a greater crit multiple than base, choose that, else default to base
	Damage.flCritMutli = CurrentAttack->flCritMulti > flBaseCritMulti ? CurrentAttack->flCritMulti : flBaseCritMulti;
	}
     else ...{}

[Rederick5]

Upon further review m_LastChargedAmt is always zero at the time of damage calculation in StrikeLand(), so this change does not alter current calculation, further investigation needed.

[Rederick5]

CGenericItem::ActivateButtonUp(), genericItem.cpp:745
CallsScriptEvent("game_-attack1") to send the attack command.

The definition to send accompanying information to the server looks like #define SendAttackCmd(AttackType) as a wrapper for UTILVars_Args, genericitems.h:166

This would pass the m_LastChargedAmount to the CMD_ARGC referenced in client.cpp:1050.

I am not sure the macro-defined cmd types are still used or this data transfer/charge calculation are now done script side, as the ATTACK_COMMAND define is not used anywhere, and this is unused else if (FStrEq(pcmd, ATTACK_COMMAND)) in client.cpp.

This calls script event: pItem->CallScriptEvent("game_setchargepercent", &parms);

Should this be used? Have not yet looked at the script side at all yet.

Edit: Now I'm not too sure, as I am using Ctrl+Shift+F to search all files and and not finding known functions, so my querying may have issues.

Yea, indexing was borked, found the call on giattack.cpp:388 in bool CGenericItem::StartAttack(int ForceAttackNum) :203

[Rederick5]

base_melee.script appears to multiple by the charge ratio. The CPP code does not effect charge versus damage.

Charge appears to do nothing unless atleast 25% charge.

if ( BWEAPON_CHARGE_PERCENT > 0.25 )
	{
		subtract BWEAPON_CHARGE_PERCENT 0.25


		local L_CHARGE_RATIO $ratio(BWEAPON_CHARGE_PERCENT,1.25,BWEAPON_DBL_CHARGE_ADJ)

		local NEW_DMG PARAM2
		multiply NEW_DMG L_CHARGE_RATIO
		setdmg dmg NEW_DMG
		return L_CHARGE_RATIO
		dbg Adjusted dmg x L_CHARGE_RATIO
		setvard BWEAPON_CHARGE_PERCENT 0

		local CUR_DRAIN MELEE_ENERGY
		multiply CUR_DRAIN BWEAPON_CHARGE_PERCENT
		drainstamina ent_owner CUR_DRAIN
	}

Confirmed StrikeLand() dmg in will be n and the final number output will be a multiplier on that despite m_LastChargedAmt being zero during server side routines.

Acid damage might fall under a different sub routine.

@SaintWish - What weapon were you using, was it a full charge level or just a partial charge level (under 1 charge level).

[SaintWish]

Any weapon will do it, I tested with a low level melee weapon since they don't apply DoTs. To get it to reproduce you have to spam click the weapon so the charge is for sure less than 25%.

[Rederick5]

Based off this I am assuming there is a timing issue where the rapid calls to the script is resulting in a race condition on some variables / desync betwen client state and script state.

The ratio function in script.cpp does not verify that the data received is within certain bounds, but given how the script populates these variables it should not be an issue.

msstring CScript::ScriptGetter_GetSkillRatio(msstring& FullName, msstring& ParserName, msstringlist& Params)
{
	//else if( ParserName == "$get_skill_ratio" || ParserName == "$ratio" )
	//priority: very high, scope: shared
	msstring Return;
	if (Params.size() >= 3)
	{
		float Ratio = atof(Params[0]);
		float Min = atof(Params[1]), Max = atof(Params[2]);

		if (Params.size() >= 4)
		{
			if (Params[3] == "inversed") Ratio = 1 - Ratio;
		}

		float Range = Max - Min;
		float Value = Min + Range * Ratio;
		RETURN_FLOAT(Value)
	}

	return FullName;
}

const BWEAPON_DBL_CHARGE_ADJ = 2.0
local L_CHARGE_RATIO $ratio(BWEAPON_CHARGE_PERCENT,1.25,BWEAPON_DBL_CHARGE_ADJ)

BWEAPON_CHARGE_PERCENT is ultimately received by SendAttackCmd() calculated then the final dmg is set script side and I am assuming returned to the server for reporting, though I still need to find exactly when it retrieved this.