Does not compile against 9.1 & 9.2 #3
Description
Compiling against 9.1 and 9.2 fails.
➜ dump_fdw git:(master) USE_PGXS=1 make
gcc -O2 -Wall -Wmissing-prototypes -Wpointer-arith -Wdeclaration-after-statement -Wendif-labels -Wformat-security -fno-strict-aliasing -fwrapv -fpic -I. -I. -I/usr/local/pgsql_9.1.18/include/server -I/usr/local/pgsql_9.1.18/include/internal -D_GNU_SOURCE -c -o dump_fdw.o dump_fdw.c
dump_fdw.c:32:33: error: access/htup_details.h: No such file or directory
dump_fdw.c:130: error: expected declaration specifiers or ‘...’ before ‘AcquireSampleRowsFunc’
dump_fdw.c: In function ‘dump_fdw_handler’:
dump_fdw.c:152: error: ‘FdwRoutine’ has no member named ‘GetForeignRelSize’
dump_fdw.c:153: error: ‘FdwRoutine’ has no member named ‘GetForeignPaths’
dump_fdw.c:154: error: ‘FdwRoutine’ has no member named ‘GetForeignPlan’
dump_fdw.c:161: error: ‘FdwRoutine’ has no member named ‘AddForeignUpdateTargets’
dump_fdw.c:162: error: ‘FdwRoutine’ has no member named ‘PlanForeignModify’
dump_fdw.c:163: error: ‘FdwRoutine’ has no member named ‘BeginForeignModify’
dump_fdw.c:164: error: ‘FdwRoutine’ has no member named ‘ExecForeignInsert’
dump_fdw.c:165: error: ‘FdwRoutine’ has no member named ‘ExecForeignUpdate’
dump_fdw.c:166: error: ‘FdwRoutine’ has no member named ‘ExecForeignDelete’
dump_fdw.c:167: error: ‘FdwRoutine’ has no member named ‘EndForeignModify’
dump_fdw.c:171: error: ‘FdwRoutine’ has no member named ‘ExplainForeignModify’
dump_fdw.c:174: error: ‘FdwRoutine’ has no member named ‘AnalyzeForeignTable’
dump_fdw.c: In function ‘dumpGetForeignRelSize’:
dump_fdw.c:334: error: ‘RelOptInfo’ has no member named ‘fdw_private’
dump_fdw.c: In function ‘dumpGetForeignPaths’:
dump_fdw.c:361: error: too many arguments to function ‘create_foreignscan_path’
dump_fdw.c: In function ‘dumpGetForeignPlan’:
dump_fdw.c:383: warning: implicit declaration of function ‘make_foreignscan’
dump_fdw.c:387: warning: return makes pointer from integer without a cast
dump_fdw.c: At top level:
dump_fdw.c:630: error: expected declaration specifiers or ‘...’ before ‘AcquireSampleRowsFunc’
dump_fdw.c: In function ‘read_int’:
dump_fdw.c:647: warning: ISO C90 forbids mixed declarations and code
dump_fdw.c: In function ‘read_str’:
dump_fdw.c:667: warning: ISO C90 forbids mixed declarations and code
dump_fdw.c: In function ‘read_toc’:
dump_fdw.c:764: warning: ISO C90 forbids mixed declarations and code
dump_fdw.c:768: warning: ISO C90 forbids mixed declarations and code
dump_fdw.c:775: warning: ISO C90 forbids mixed declarations and code
dump_fdw.c:778: warning: ISO C90 forbids mixed declarations and code
dump_fdw.c:784: warning: ISO C90 forbids mixed declarations and code
dump_fdw.c:790: warning: ISO C90 forbids mixed declarations and code
dump_fdw.c:799: warning: ISO C90 forbids mixed declarations and code
dump_fdw.c: In function ‘field_cb’:
dump_fdw.c:906: warning: ISO C90 forbids mixed declarations and code
dump_fdw.c:917: warning: ISO C90 forbids mixed declarations and code
make: *** [dump_fdw.o] Error 1
It seems fixing the issue or changing the docs are both valid solutions.