From eb93f52eadf078cbc886dce60db257a2583f83bb Mon Sep 17 00:00:00 2001 From: JulianMaurin Date: Wed, 25 Feb 2026 09:54:16 +0100 Subject: [PATCH] fix(ci): request @devs review until review conditions are fully satisfied MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Previously, the review request rule used `#approved-reviews-by=0`, which stopped requesting @devs after the first approval — even when a second approval was still needed. Now checks the actual review conditions (DefaultReviewCond) so @devs keeps being requested until the requirements are truly met. Co-Authored-By: Claude Opus 4.6 Change-Id: I8a004dd8b97ad77417fdc2b4fa64aecbb9c8f14f --- .mergify.yml | 16 +++++++++------- 1 file changed, 9 insertions(+), 7 deletions(-) diff --git a/.mergify.yml b/.mergify.yml index 626a98b6..abd71569 100644 --- a/.mergify.yml +++ b/.mergify.yml @@ -2,6 +2,11 @@ extends: .github shared: check_runs: &CheckRuns - check-success=ci-gate + default_review_cond: &DefaultReviewCond + - "#approved-reviews-by>=2" + - author = dependabot[bot] + - author = renovate[bot] + - author = mergify-ci-bot queue_rules: - name: dependencies @@ -38,9 +43,10 @@ pull_request_rules: - -merged - -closed - and: *CheckRuns - - "#approved-reviews-by=0" - "#changes-requested-reviews-by=0" - - "review-requested!=@devs" + - review-requested!=@devs + - not: + or: *DefaultReviewCond actions: request_reviews: teams: @@ -56,11 +62,7 @@ merge_protections: - name: 👀 Review Requirements if: [] success_conditions: - - or: - - "#approved-reviews-by>=2" - - author = dependabot[bot] - - author = renovate[bot] - - author = mergify-ci-bot + - or: *DefaultReviewCond merge_queue: