Skip to content

Some small bugs? #1

@tycacz

Description

@tycacz

Hi Tomasz,
I have probably found some small bugs in your code. I hope that you will check it and maybe it will helps to you to improve your code. Please feel free to tell me if I'm wrong.
Best regards,
Martin Mostek
Ps: Thank You very much for your bootloader code, it helps me in my understanding of the STM Bootloader.

Bugs report:
In ExtendedErase function is wrong check sum :
/* checksum /
tx[6] = (byte)~ComputeChecksum(tx, 2, 5);
it should be:
/
checksum */
tx[6] = (byte)~ComputeChecksum(tx, 2, 4);

next (the same bug):
in EraseSpecial function is wrong check sum :
/* checksum /
tx[3] = (byte)~ComputeChecksum(tx, 2, 2);
it should be:
/
checksum */
tx[3] = (byte)~ComputeChecksum(tx, 2, 1);

and finally:
in ExtendedEraseSpecial function is wrong check sum :
/* checksum /
tx[4] = (byte)~ComputeChecksum(tx, 2, 3);
it should be:
/
checksum */
tx[4] = (byte)~ComputeChecksum(tx, 2, 2);

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions