Request: Preserve Entity Data on Ship Move

[ColonelKai]

Is your feature request related to a problem? Please describe.
Had a cool Venetian flag, it became the base color when i moved :(

It seems that all entities moving with the ship have their NBT's reset, be it a sheep's color, a hostile mob's armor, and yes, the banners. Which makes me sad the most.

Describe the solution you'd like
For it to preserve entity data on ship move.

[mosemister]

This is difficult, mainly because of the translation layer and the fact Bukkit doesn't allow setting NBT data, so the translation layer goes though every possible getter with setter known, saves the value and then sets it after the fact.

So sadly I can fix specific issues, but generic ones like that, I would need to find all the values you mean and hope they have setters and getters

[mosemister]

Here are all the current translations going on in Bukkit

https://github.com/Minecraft-Ships/CoreToBukkit/blob/master/src/main/java/org/ships/implementation/bukkit/entity/EntitySnapshotValue.java